Make PUT/PATCH api async for function on aca #27612

vishal1997 · 2024-02-01T07:12:37Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-02-01T07:12:41Z

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2024-02-01T07:12:41Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 17 Errors, 12 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
WebApps.json	2023-12-01(a30f310)	2023-01-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L271:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1148:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1937:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2496:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2560:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L973:9 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29134:13
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'id' renamed or removed? New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'name' renamed or removed? New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'kind' renamed or removed? New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'type' renamed or removed? New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L972:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29129:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L227:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L221:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L298:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L282:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1107:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L1090:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L1896:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L1869:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2455:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L2418:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L2519:7 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L2472:7
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6390:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6333:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L964:9 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29130:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6425:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6368:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6439:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6382:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6515:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6458:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L6529:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L6472:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15511:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15454:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15546:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15489:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15567:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15510:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15650:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15593:13
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Web/stable/2023-12-01/WebApps.json#L15671:13 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L15614:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Web/stable/2023-12-01/CommonDefinitions.json#L969:5 Old: Microsoft.Web/stable/2023-01-01/WebApps.json#L29121:5

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-01T07:12:42Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-go - sdk/resourcemanager/appservice/armappservice - Approved - 3.0.0

+	Field `ID`, `Kind`, `Name`, `Properties`, `Type` of struct `SwiftVirtualNetwork` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckResponse` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckSlotResponse` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientGetSwiftVirtualNetworkConnectionResponse` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientGetSwiftVirtualNetworkConnectionSlotResponse` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckResponse` has been removed
+	Field `SwiftVirtualNetwork` of struct `WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckSlotResponse` has been removed
+	Function `*WebAppsClient.CreateOrUpdateSwiftVirtualNetworkConnectionWithCheckSlot` parameter(s) have been changed from `(context.Context, string, string, string, SwiftVirtualNetwork, *WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckSlotOptions)` to `(context.Context, string, string, string, SwiftVirtualNetworkProxy, *WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckSlotOptions)`
+	Function `*WebAppsClient.CreateOrUpdateSwiftVirtualNetworkConnectionWithCheck` parameter(s) have been changed from `(context.Context, string, string, SwiftVirtualNetwork, *WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckOptions)` to `(context.Context, string, string, SwiftVirtualNetworkProxy, *WebAppsClientCreateOrUpdateSwiftVirtualNetworkConnectionWithCheckOptions)`
+	Function `*WebAppsClient.UpdateSwiftVirtualNetworkConnectionWithCheckSlot` parameter(s) have been changed from `(context.Context, string, string, string, SwiftVirtualNetwork, *WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckSlotOptions)` to `(context.Context, string, string, string, SwiftVirtualNetworkProxy, *WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckSlotOptions)`
+	Function `*WebAppsClient.UpdateSwiftVirtualNetworkConnectionWithCheck` parameter(s) have been changed from `(context.Context, string, string, SwiftVirtualNetwork, *WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckOptions)` to `(context.Context, string, string, SwiftVirtualNetworkProxy, *WebAppsClientUpdateSwiftVirtualNetworkConnectionWithCheckOptions)`
+	Operation `*WebAppsClient.CreateOrUpdateConfiguration` has been changed to LRO, use `*WebAppsClient.BeginCreateOrUpdateConfiguration` instead.
+	Operation `*WebAppsClient.Delete` has been changed to LRO, use `*WebAppsClient.BeginDelete` instead.
+	Operation `*WebAppsClient.UpdateApplicationSettings` has been changed to LRO, use `*WebAppsClient.BeginUpdateApplicationSettings` instead.
+	Operation `*WebAppsClient.UpdateConfiguration` has been changed to LRO, use `*WebAppsClient.BeginUpdateConfiguration` instead.
+	Operation `*WebAppsClient.UpdateConnectionStrings` has been changed to LRO, use `*WebAppsClient.BeginUpdateConnectionStrings` instead.
+	Operation `*WebAppsClient.Update` has been changed to LRO, use `*WebAppsClient.BeginUpdate` instead.
+	Struct `SwiftVirtualNetworkProperties` has been removed

⚠️azure-sdk-for-js - @azure/arm-appservice - Approved - 15.0.0

+	Operation WebApps.createOrUpdateSwiftVirtualNetworkConnectionWithCheck has a new signature
+	Operation WebApps.createOrUpdateSwiftVirtualNetworkConnectionWithCheckSlot has a new signature
+	Operation WebApps.updateSwiftVirtualNetworkConnectionWithCheck has a new signature
+	Operation WebApps.updateSwiftVirtualNetworkConnectionWithCheckSlot has a new signature
+	Removed operation WebApps.createOrUpdateConfiguration
+	Removed operation WebApps.delete
+	Removed operation WebApps.update
+	Removed operation WebApps.updateApplicationSettings
+	Removed operation WebApps.updateConfiguration
+	Removed operation WebApps.updateConnectionStrings

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m

❌Azure.ResourceManager.AppService [View full logs] [Preview SDK Changes] Breaking Change Detected

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh]    Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     06k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
cmderr	[init.sh]
cmderr	[init.sh] npm notice New major version of npm available! 9.5.0 -> 10.4.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
cmderr	[init.sh] npm notice Run `npm install -g npm@10.4.0` to update!
cmderr	[init.sh] npm notice
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appservice-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appservice/armappservice [View full logs] [Preview SDK Changes] Breaking Change Detected

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appservice [View full logs] [Preview SDK Changes] Breaking Change Detected
- azure-arm-appservice-15.0.0.tgz

️🔄 azure-resource-manager-schemas inProgress [Detail]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from 4aac66a447116e86d77bb58f9fdcccf8485eb76a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.web.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-01T07:12:43Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appservice/armappservice	https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=c301912f1a084d1a83ee6dd28821374d
Java	azure-resourcemanager-appservice-generated	https://apiview.dev/Assemblies/Review/a2b80e4fbd144844bca0c504ef8c3337?revisionId=507c2600a91d4408ba9a9b8ba1a524d7
JavaScript	@azure/arm-appservice	https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=c3ecc34bda1742849b0c7eeb693ce2b9

visingla-ms · 2024-02-02T13:43:47Z

        "description": "Successfully deleted web app."

Remove 200 response from Async Delete, only 202 and 204 are required.

Refers to: specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json:260 in 00137e9. [](commit_id = 00137e9, deletion_comment = False)

specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json

openapi-workflow-bot · 2024-02-02T13:46:50Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

vishal1997 · 2024-02-05T13:11:37Z

        "description": "Successfully deleted web app."
Remove 200 response from Async Delete, only 202 and 204 are required.

Refers to: specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json:260 in 00137e9. [](commit_id = 00137e9, deletion_comment = False)

The delete API can still return 200 for sync operations.

mentat9 · 2024-02-08T00:13:47Z

        "description": "Successfully deleted web app."
Remove 200 response from Async Delete, only 202 and 204 are required.
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json:260 in 00137e9. [](commit_id = 00137e9, deletion_comment = False)
The delete API can still return 200 for sync operations.

Your APIs should not be sometimes sync and sometimes async on the same method. If DELETE is async, it should always be async. That's why 200 is no longer used for DELETE response.

mentat9 · 2024-02-08T02:17:02Z

  "delete": {

Changing a method from sync to async is a breaking change.

Refers to: specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json:221 in 00137e9. [](commit_id = 00137e9, deletion_comment = False)

vishal1997 · 2024-02-08T11:28:26Z

        "description": "Successfully deleted web app."
Remove 200 response from Async Delete, only 202 and 204 are required.
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json:260 in 00137e9. [](commit_id = 00137e9, deletion_comment = False)
The delete API can still return 200 for sync operations.
Your APIs should not be sometimes sync and sometimes async on the same method. If DELETE is async, it should always be async. That's why 200 is no longer used for DELETE response.

Is the rule different for delete API, there are other PUT APIs with both 200, 202.

azure-rest-api-specs/specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/AppServicePlans.json

Line 198 in a30f310

"202": {

Also, this delete API internally calls Microsoft.App RP delete API which has both 202, 200. https://learn.microsoft.com/en-us/rest/api/containerapps/container-apps/delete?view=rest-containerapps-2023-05-01&tabs=HTTP

kazrael2119 · 2024-02-20T07:20:23Z

please get BreakingChange approval before reviewing sdk breaking changes

vishal1997 · 2024-02-20T12:10:38Z

please get BreakingChange approval before reviewing sdk breaking changes

#27251
As per comments in this PR, the breaking change approval will be required when the final release version is merged to main branch

edwin-msft · 2024-02-23T21:03:10Z

specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json

+          "202": {
+            "description": "Asynchronous operation in progress.",
+            "headers": {
+              "location": {


ARM's guidance is here:
https://armwiki.azurewebsites.net/rpaas/async.html#creating-or-updating-resources-put
Put/Patch/Post

Seems like the header to use is Azure-AsyncOperation. Should we use that?

I noticed that the examples all use Azure-AsyncOperation for some reason

This reverts commit cd214ae.

* Introduce Microsoft.Web API version 2023-12-01 (#27100) * Add VnetBackupRestoreEnabled property to the latest API Version (#27175) * changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317) Co-authored-by: Xingyang Li <xingyangli@microsoft.com> * e2e encryption (#27226) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Adding Vnet-related APIs to Swagger (#27251) * Add function app config to latest Web API (#27358) * Add functionAppConfig definition * Add create or update function app Flex Consumption example * Add create or update function app Flex Consumption with details example * Update CommonDefinitions.json to reference the new examples * Make PUT/PATCH api async for function on aca (#27612) * Make PUT/PATCH api async for function on aca * Remove response body * update examples * Add headers --------- Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> * Add FlexConsumption to the list of supported skus (#27951) * Add TLS1.3 to valid TLS Versions (#27885) Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm * Added Linux SiteContainer APIs (#27942) * Added Linux SiteContainer APIs * Resolved validation failures. * Added SiteContainer and SiteContainerCollection * Fixed LintDiff errors * Fixed spellings * Updated params order. * Resolving comments. * Resolving comments. * Added volumeMounts and envVariables. * Resolving comments * Resolving comments * Removed type and metadata. * Haochidu/release web 2023 12 01/aseregion hotfix (#28018) * Update ResourceProvider.json hot fix API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification. * Update ResourceProvider.json * Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249) This reverts commit 0765e9d. * Add DnsConfiguration site property to Microsoft.Web API Specs (#27378) * Add DnsConfiguration property to WebApps.json * Add SiteDnsConfig to CommonDefinitions.json * Updated dnslegacy property description * Update CommonDefinitions.json * Undo previous update to CommonDefinitions.json * Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder * Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289) Co-authored-by: Amber Renton <amberrenton@microsoft.com> * Update create function app examples for Flex Consumption (#28566) * Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568) This reverts commit cd214ae. * Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738) This reverts commit ec1d84f. * create sdk-suppression.yaml (#28751) * create sdk-suppression.yaml * add azure-sdk-for-go suppression --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com> Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com> Co-authored-by: Xingyang Li <xingyangli@microsoft.com> Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com> Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com> Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com> Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com> Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com> Co-authored-by: Amber Renton <amberrenton@microsoft.com> Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Alancere <804873052@qq.com>

Make PUT/PATCH api async for function on aca

4d0e633

vishal1997 requested a review from naveedaz as a code owner February 1, 2024 07:12

azure-sdk mentioned this pull request Feb 1, 2024

[AutoPR sdk/resourcemanager/appservice/armappservice] Make PUT/PATCH api async for function on aca azure-sdk/azure-sdk-for-go#8731

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 1, 2024

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 1, 2024

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 1, 2024

azure-sdk mentioned this pull request Feb 1, 2024

[AutoPR Azure.ResourceManager.AppService] Make PUT/PATCH api async for function on aca azure-sdk/azure-sdk-for-net#6856

Closed

Remove response body

92ef308

vishal1997 force-pushed the release-web-2023-12-01 branch 2 times, most recently from b45fbbc to bd4efdd Compare February 1, 2024 08:53

update examples

00137e9

vishal1997 force-pushed the release-web-2023-12-01 branch from bd4efdd to 00137e9 Compare February 1, 2024 08:57

visingla-ms reviewed Feb 2, 2024

View reviewed changes

specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/WebApps.json Outdated Show resolved Hide resolved

visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 2, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2024

vishal1997 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 5, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 5, 2024

mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 8, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 8, 2024

mentat9 added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 8, 2024

Add headers

a30f310

AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 8, 2024

vishal1997 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 8, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 8, 2024

vishal1997 added the IDCDevDiv label Feb 13, 2024

krisnaray added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 20, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 20, 2024

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Feb 21, 2024

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 22, 2024

vishal1997 added the MergeRequested label Feb 23, 2024

ms-henglu approved these changes Feb 23, 2024

View reviewed changes

ms-henglu merged commit cd214ae into Azure:release-web-2023-12-01 Feb 23, 2024
23 of 27 checks passed

edwin-msft reviewed Feb 23, 2024

View reviewed changes

naveedaz mentioned this pull request Mar 19, 2024

Release web 2023 12 01 #28268

Merged

7 tasks

vivekjilla mentioned this pull request Apr 11, 2024

Revert "Make PUT/PATCH api async for function on aca (#27612)" #28568

Merged

7 tasks

naveedaz added a commit that referenced this pull request Apr 11, 2024

Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568)

0db58f3

This reverts commit cd214ae.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make PUT/PATCH api async for function on aca #27612

Make PUT/PATCH api async for function on aca #27612

vishal1997 commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

visingla-ms commented Feb 2, 2024

openapi-workflow-bot bot commented Feb 2, 2024

vishal1997 commented Feb 5, 2024

mentat9 commented Feb 8, 2024

mentat9 commented Feb 8, 2024

vishal1997 commented Feb 8, 2024

kazrael2119 commented Feb 20, 2024

vishal1997 commented Feb 20, 2024

edwin-msft Feb 23, 2024

Make PUT/PATCH api async for function on aca #27612

Make PUT/PATCH api async for function on aca #27612

Conversation

vishal1997 commented Feb 1, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Generated ApiView

visingla-ms commented Feb 2, 2024

openapi-workflow-bot bot commented Feb 2, 2024

vishal1997 commented Feb 5, 2024

mentat9 commented Feb 8, 2024

mentat9 commented Feb 8, 2024

vishal1997 commented Feb 8, 2024

kazrael2119 commented Feb 20, 2024

vishal1997 commented Feb 20, 2024

edwin-msft Feb 23, 2024

Choose a reason for hiding this comment

vishal1997 commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading