-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release machinelearningservices microsoft.machine learning services 2024 04 01 preview #27840
Release machinelearningservices microsoft.machine learning services 2024 04 01 preview #27840
Conversation
… preview/2024-01-01-preview to version 2024-04-01-preview
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.7) | new version | base version |
---|---|---|
mfe.json | 2024-01-01-preview(65e61fe) | 2024-01-01-preview(main) |
️❌
Breaking Change(Cross-Version): 87 Errors, 3 Warnings failed [Detail]
Compared specs (v0.10.7) | new version | base version |
---|---|---|
machineLearningServices.json | 2024-04-01-preview(65e61fe) | 2023-10-01(main) |
machineLearningServices.json | 2024-04-01-preview(65e61fe) | 2024-01-01-preview(main) |
mfe.json | 2024-04-01-preview(65e61fe) | 2023-10-01(main) |
mfe.json | 2024-04-01-preview(65e61fe) | 2024-01-01-preview(main) |
registries.json | 2024-04-01-preview(65e61fe) | 2023-10-01(main) |
registries.json | 2024-04-01-preview(65e61fe) | 2024-01-01-preview(main) |
workspaceFeatures.json | 2024-04-01-preview(65e61fe) | 2023-10-01(main) |
workspaceFeatures.json | 2024-04-01-preview(65e61fe) | 2024-01-01-preview(main) |
workspaceRP.json | 2024-04-01-preview(65e61fe) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L73:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L294:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L339:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L415:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L457:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L704:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1098:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1318:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1363:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1503:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1545:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1607:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1649:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1691:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1828:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1878:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1923:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules/{ruleName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1971:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/provisionManagedNetwork' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2153:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspacePropertiesUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'DiagnoseRequestProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'DiagnoseWorkspaceParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpoint' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionState' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
The new version is missing a client parameter that was found in the old version. Was 'AOAIModelsToDeployParameter' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L6688:3 Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L5120:3 |
|
The optional parameter 'aoaiModelsToDeploy' was removed in the new version. Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L519:9 |
|
The optional parameter 'aoaiModelsToDeploy' was removed in the new version. Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L684:9 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Note to ARM reviewer: I have added a lintdiff approval to this PR because the check is timing out and not expected to complete. This is because of the number of files that need to be run thru this process. The reviewer needs to manually review all changes as they cannot rely on the automated checks. |
...source-manager/Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json
Show resolved
Hide resolved
...source-manager/Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json
Show resolved
Hide resolved
@ms-henglu , The comments from yesterday have been addressed with this PR #28460 . Could we now get the sign off on this PR please? |
There's still a comment not responded: #27840 (comment) |
@ms-henglu - This is the PR to address the comment above #28495. Could you please review? |
* Update status code * remove suppression
* Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api
/pr RequestMerge |
…024 04 01 preview (#27840) * Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Update mfe.json (#28205) * Os Patching Result for ComputeInstance property (#28242) * move ospatching result message to a more appropriate place (#28306) * [ML]WRP 2024-04-01-preview swagger changes (#28311) * changes for 04-01-preview and examples * Fix and run prettier Fix and run prettier * Fix operation Id issue * Fix lint error * small fix on rai policy schema * Fix example * Add missing fix * Fix issue and add suppression * Update example * Fix * Fix example issue * prettier fix * Add description (#28460) * [ML] Update deployment API status code from 202 to 201 (#28495) * Update status code * remove suppression * [ML] Add missing connection APIs in 04-01-preview version (#28662) * Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api --------- Co-authored-by: Brian Hungerman <brianhungerman@gmail.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.