Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release machinelearningservices microsoft.machine learning services 2024 04 01 preview #27840

Conversation

MilesHolland
Copy link
Member

@MilesHolland MilesHolland commented Feb 20, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

Copy link

openapi-pipeline-app bot commented Feb 20, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Feb 20, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.7) new version base version
mfe.json 2024-01-01-preview(65e61fe) 2024-01-01-preview(main)
️❌Breaking Change(Cross-Version): 87 Errors, 3 Warnings failed [Detail]
Compared specs (v0.10.7) new version base version
machineLearningServices.json 2024-04-01-preview(65e61fe) 2023-10-01(main)
machineLearningServices.json 2024-04-01-preview(65e61fe) 2024-01-01-preview(main)
mfe.json 2024-04-01-preview(65e61fe) 2023-10-01(main)
mfe.json 2024-04-01-preview(65e61fe) 2024-01-01-preview(main)
registries.json 2024-04-01-preview(65e61fe) 2023-10-01(main)
registries.json 2024-04-01-preview(65e61fe) 2024-01-01-preview(main)
workspaceFeatures.json 2024-04-01-preview(65e61fe) 2023-10-01(main)
workspaceFeatures.json 2024-04-01-preview(65e61fe) 2024-01-01-preview(main)
workspaceRP.json 2024-04-01-preview(65e61fe) 2024-01-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L73:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L294:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L339:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L415:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L457:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L704:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1098:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1318:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1363:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1503:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1545:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1607:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1649:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1691:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1828:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1878:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1923:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules/{ruleName}' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1971:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/provisionManagedNetwork' removed or restructured?
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2153:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'WorkspaceUpdateParameters' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'WorkspacePropertiesUpdateParameters' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DiagnoseRequestProperties' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DiagnoseWorkspaceParameters' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProperties' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpoint' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionState' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3
Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'AOAIModelsToDeployParameter' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L6688:3
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L5120:3
⚠️ 1046 - RemovedOptionalParameter The optional parameter 'aoaiModelsToDeploy' was removed in the new version.
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L519:9
⚠️ 1046 - RemovedOptionalParameter The optional parameter 'aoaiModelsToDeploy' was removed in the new version.
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L684:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Feb 20, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m
  • Azure.ResourceManager.MachineLearning [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/machinelearning/armmachinelearning [Preview SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.2` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️azure-mgmt-machinelearningservices [Preview SDK Changes]
    • azure-mgmt-machinelearningservices-1.0.0b1.zip
    • azure_mgmt_machinelearningservices-1.0.0b1-py3-none-any.whl
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-machinelearning [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-machinelearning-1.1.0-beta.1.jar
    • azure-resourcemanager-machinelearning-1.1.0-beta.1-sources.jar
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-machinelearning [Preview SDK Changes]
    • azure-arm-machinelearning-3.0.0-beta.1.tgz
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.2` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️machinelearningservices [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 05b65d51df9107065286724f62ebc6b2e0098eff. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.machinelearningservices.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Feb 20, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Feb 20, 2024
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@ragovada ragovada marked this pull request as draft February 22, 2024 18:18
@rkmanda
Copy link
Member

rkmanda commented Feb 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@rkmanda
Copy link
Member

rkmanda commented Feb 23, 2024

Note to ARM reviewer: I have added a lintdiff approval to this PR because the check is timing out and not expected to complete. This is because of the number of files that need to be run thru this process. The reviewer needs to manually review all changes as they cannot rely on the automated checks.

@mikekistler mikekistler added BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. and removed BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR labels Mar 7, 2024
@ms-henglu ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 26, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2024
@ragovada
Copy link
Member

@ms-henglu , The comments from yesterday have been addressed with this PR #28460 . Could we now get the sign off on this PR please?

@ms-henglu ms-henglu removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 27, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 27, 2024
@ms-henglu
Copy link
Member

There's still a comment not responded: #27840 (comment)

@ms-henglu ms-henglu added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 27, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 27, 2024
@ragovada
Copy link
Member

ragovada commented Mar 28, 2024

@ms-henglu - This is the PR to address the comment above #28495. Could you please review?

@ms-henglu ms-henglu removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 29, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 29, 2024
* Update status code

* remove suppression
@ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 29, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Apr 15, 2024
* Add connection missing APIs

* Update example and connection ids

* Add missing parameter

* Update suppression

* Update api
@ragovada
Copy link
Member

/pr RequestMerge

@raosuhas raosuhas merged commit 6eda980 into main Apr 17, 2024
31 of 32 checks passed
@raosuhas raosuhas deleted the release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01-preview branch April 17, 2024 00:43
tjprescott pushed a commit that referenced this pull request Apr 17, 2024
…024 04 01 preview (#27840)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update mfe.json (#28205)

* Os Patching Result for ComputeInstance property (#28242)

* move ospatching result message to a more appropriate place (#28306)

* [ML]WRP 2024-04-01-preview swagger changes (#28311)

* changes for 04-01-preview and examples

* Fix and run prettier

Fix and run prettier

* Fix operation Id issue

* Fix lint error

* small fix on rai policy schema

* Fix example

* Add missing fix

* Fix issue and add suppression

* Update example

* Fix

* Fix example issue

* prettier fix

* Add description (#28460)

* [ML] Update deployment API status code from 202 to 201 (#28495)

* Update status code

* remove suppression

* [ML] Add missing connection APIs in 04-01-preview version (#28662)

* Add connection missing APIs

* Update example and connection ids

* Add missing parameter

* Update suppression

* Update api

---------

Co-authored-by: Brian Hungerman <brianhungerman@gmail.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants