-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark MOE API Contract MaxQueueWait as deprecated #28205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Compared specs (v0.10.5) | new version | base version |
---|---|---|
mfe.json | 2024-01-01-preview(91ab2e9) | 2024-01-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 11, 2024
There wont be lint diff as I am just adding whatever is in GA to preview. I'll have to ask ARM for the supression of lint diff |
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Mar 12, 2024
raosuhas
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Mar 12, 2024
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Mar 12, 2024
/pr requestmerge |
Lintdiff error can be ignored since there seems to be some issue with the tool. Change is only in description. |
/pr requestmerge |
raosuhas
approved these changes
Mar 13, 2024
raosuhas
merged commit Mar 13, 2024
e1649ed
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01-preview
27 of 28 checks passed
raosuhas
pushed a commit
that referenced
this pull request
Apr 17, 2024
…024 04 01 preview (#27840) * Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Update mfe.json (#28205) * Os Patching Result for ComputeInstance property (#28242) * move ospatching result message to a more appropriate place (#28306) * [ML]WRP 2024-04-01-preview swagger changes (#28311) * changes for 04-01-preview and examples * Fix and run prettier Fix and run prettier * Fix operation Id issue * Fix lint error * small fix on rai policy schema * Fix example * Add missing fix * Fix issue and add suppression * Update example * Fix * Fix example issue * prettier fix * Add description (#28460) * [ML] Update deployment API status code from 202 to 201 (#28495) * Update status code * remove suppression * [ML] Add missing connection APIs in 04-01-preview version (#28662) * Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api --------- Co-authored-by: Brian Hungerman <brianhungerman@gmail.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
tjprescott
pushed a commit
that referenced
this pull request
Apr 17, 2024
…024 04 01 preview (#27840) * Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Update mfe.json (#28205) * Os Patching Result for ComputeInstance property (#28242) * move ospatching result message to a more appropriate place (#28306) * [ML]WRP 2024-04-01-preview swagger changes (#28311) * changes for 04-01-preview and examples * Fix and run prettier Fix and run prettier * Fix operation Id issue * Fix lint error * small fix on rai policy schema * Fix example * Add missing fix * Fix issue and add suppression * Update example * Fix * Fix example issue * prettier fix * Add description (#28460) * [ML] Update deployment API status code from 202 to 201 (#28495) * Update status code * remove suppression * [ML] Add missing connection APIs in 04-01-preview version (#28662) * Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api --------- Co-authored-by: Brian Hungerman <brianhungerman@gmail.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-LintDiff
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.