Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update deployment API status code from 202 to 201 #28495

Conversation

ZhidaLiu
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 3 Warnings warning [Detail]
Compared specs (v0.10.7) new version base version
workspaceRP.json 2024-04-01-preview(aab622b) 2024-01-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'AOAIModelsToDeployParameter' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L6063:3
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L5120:3
⚠️ 1046 - RemovedOptionalParameter The optional parameter 'aoaiModelsToDeploy' was removed in the new version.
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L519:9
⚠️ 1046 - RemovedOptionalParameter The optional parameter 'aoaiModelsToDeploy' was removed in the new version.
Old: Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json#L684:9
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-preview-2024-04 package-preview-2024-04(aab622b) package-preview-2024-04(release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
SecurityDefinitionsStructure Every OpenAPI(swagger) spec/configuration must have a security definitions section and it must adhere to the following structure: https://github.com/Azure/azure-openapi-validator/blob/main/docs/security-definitions-structure-validation.md
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L1
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L162
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L252
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L299
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyVaultProperties.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L299
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyIdentifier.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L299
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L299
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L307
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L311
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L328
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L328
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L366
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:authType.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L588
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L613
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L1556
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L1556
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L1798
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L1798
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2453
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2479
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2546
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2656
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2656
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2656
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2823
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2920
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2937
ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L2978
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L3023
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.MachineLearningServices/preview/2024-04-01-preview/workspaceRP.json#L3119
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m
  • Azure.ResourceManager.MachineLearning [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/machinelearning/armmachinelearning [View full logs]  [Preview SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-machinelearningservices [View full logs]  [Preview SDK Changes]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh]  Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     06972
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-machinelearning [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-machinelearning [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️machinelearningservices [View full logs]  [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 1f37a98a80679488a16c8579915055c266652dcc. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.machinelearningservices.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 28, 2024
@ragovada ragovada requested a review from rkmanda March 28, 2024 17:56
@ZhidaLiu ZhidaLiu requested a review from ms-henglu March 29, 2024 00:13
@ZhidaLiu
Copy link
Member Author

@ms-henglu it will be great if you can review this PR as this is a fix requested by the staging branch we are trying to merge, you can see the request is from this comment:
#27840 (comment)

@ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 29, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 29, 2024
@ms-henglu ms-henglu merged commit 88effb4 into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01-preview Mar 29, 2024
25 of 27 checks passed
raosuhas pushed a commit that referenced this pull request Apr 17, 2024
…024 04 01 preview (#27840)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update mfe.json (#28205)

* Os Patching Result for ComputeInstance property (#28242)

* move ospatching result message to a more appropriate place (#28306)

* [ML]WRP 2024-04-01-preview swagger changes (#28311)

* changes for 04-01-preview and examples

* Fix and run prettier

Fix and run prettier

* Fix operation Id issue

* Fix lint error

* small fix on rai policy schema

* Fix example

* Add missing fix

* Fix issue and add suppression

* Update example

* Fix

* Fix example issue

* prettier fix

* Add description (#28460)

* [ML] Update deployment API status code from 202 to 201 (#28495)

* Update status code

* remove suppression

* [ML] Add missing connection APIs in 04-01-preview version (#28662)

* Add connection missing APIs

* Update example and connection ids

* Add missing parameter

* Update suppression

* Update api

---------

Co-authored-by: Brian Hungerman <brianhungerman@gmail.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
tjprescott pushed a commit that referenced this pull request Apr 17, 2024
…024 04 01 preview (#27840)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update mfe.json (#28205)

* Os Patching Result for ComputeInstance property (#28242)

* move ospatching result message to a more appropriate place (#28306)

* [ML]WRP 2024-04-01-preview swagger changes (#28311)

* changes for 04-01-preview and examples

* Fix and run prettier

Fix and run prettier

* Fix operation Id issue

* Fix lint error

* small fix on rai policy schema

* Fix example

* Add missing fix

* Fix issue and add suppression

* Update example

* Fix

* Fix example issue

* prettier fix

* Add description (#28460)

* [ML] Update deployment API status code from 202 to 201 (#28495)

* Update status code

* remove suppression

* [ML] Add missing connection APIs in 04-01-preview version (#28662)

* Add connection missing APIs

* Update example and connection ids

* Add missing parameter

* Update suppression

* Update api

---------

Co-authored-by: Brian Hungerman <brianhungerman@gmail.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants