-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Os Patching Result property for ComputeInstance #28242
Os Patching Result property for ComputeInstance #28242
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Compared specs (v0.10.5) | new version | base version |
---|---|---|
machineLearningServices.json | 2024-04-01-preview(334246c) | 2023-10-01(main) |
machineLearningServices.json | 2024-04-01-preview(334246c) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.MachineLearningServices/operations' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L73:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L294:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/diagnose' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L339:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L415:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/resyncKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L457:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L704:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookAccessToken' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1098:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1318:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1363:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/privateLinkResources' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1503:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1545:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listStorageAccountKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1607:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/listNotebookKeys' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1649:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1691:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1828:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundNetworkDependenciesEndpoints' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1878:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1923:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/outboundRules/{ruleName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L1971:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/provisionManagedNetwork' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2153:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspaceUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'WorkspacePropertiesUpdateParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'DiagnoseRequestProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'DiagnoseWorkspaceParameters' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProperties' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateEndpoint' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionState' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-04-01-preview/machineLearningServices.json#L1101:3 Old: Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json#L2357:3 |
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛
PR Summary pending [Detail]
️⌛
Automated merging requirements met pending [Detail]
Swagger Generation Artifacts
|
Generated ApiView
|
a8ca69d
to
334246c
Compare
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
FYI ARM Reviewer, The breaking change failures for Removed Path, Removed Definition and Removed client parameter on this PR are not new and are inherited from here https://github.com/Azure/azure-rest-api-specs/pull/24249 where they have already been approved. Also, the Constraint Changed breaking change failures are pre-existing from the last preview version https://github.com/Azure/azure-rest-api-specs/pull/27320/checks?check_run_id=21131349929. Could you please review and add the approval for the same? Regarding Lint diff check it's been running and not completed. We need this PR to be merged into our staging branch to be able to make it to MFE April Preview. Could you please help? Thank you |
/pr RequestMerge |
/azp run |
Commenter does not have sufficient privileges for PR 28242 in repo Azure/azure-rest-api-specs |
d3dcbe4
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-04-01-preview
…024 04 01 preview (#27840) * Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Update mfe.json (#28205) * Os Patching Result for ComputeInstance property (#28242) * move ospatching result message to a more appropriate place (#28306) * [ML]WRP 2024-04-01-preview swagger changes (#28311) * changes for 04-01-preview and examples * Fix and run prettier Fix and run prettier * Fix operation Id issue * Fix lint error * small fix on rai policy schema * Fix example * Add missing fix * Fix issue and add suppression * Update example * Fix * Fix example issue * prettier fix * Add description (#28460) * [ML] Update deployment API status code from 202 to 201 (#28495) * Update status code * remove suppression * [ML] Add missing connection APIs in 04-01-preview version (#28662) * Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api --------- Co-authored-by: Brian Hungerman <brianhungerman@gmail.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
…024 04 01 preview (#27840) * Adds base for updating Microsoft.MachineLearningServices from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Update mfe.json (#28205) * Os Patching Result for ComputeInstance property (#28242) * move ospatching result message to a more appropriate place (#28306) * [ML]WRP 2024-04-01-preview swagger changes (#28311) * changes for 04-01-preview and examples * Fix and run prettier Fix and run prettier * Fix operation Id issue * Fix lint error * small fix on rai policy schema * Fix example * Add missing fix * Fix issue and add suppression * Update example * Fix * Fix example issue * prettier fix * Add description (#28460) * [ML] Update deployment API status code from 202 to 201 (#28495) * Update status code * remove suppression * [ML] Add missing connection APIs in 04-01-preview version (#28662) * Add connection missing APIs * Update example and connection ids * Add missing parameter * Update suppression * Update api --------- Co-authored-by: Brian Hungerman <brianhungerman@gmail.com> Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.