Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created folder for 2018-07-01 api version #3509

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

MikhailTryakhov
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov commented Jul 26, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp90_nrr20/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp90_nrr20/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.109', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4282).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.109->2.1.109)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-05"} .
Failure during batch task - {"tag":"package-2018-05"} -- Error: [Exception] No input files provided.

Use --help to get help information..
[Exception] No input files provided.

Use --help to get help information.

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1518

@@ -745,7 +778,7 @@ directive:
- suppress: DefinitionsPropertiesNamesCamelCase
from: networkwatcher.json
where: $.definitions.ProtocolConfiguration.properties.HTTPConfiguration
reason: Accidentally shipped with wrong casing however fixing the casing is introducing a breaking change which is worse than living with the naming violation
reason: Accidentally shipped with wrong casing – however fixing the casing is introducing a breaking change which is worse than living with the naming violation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somthing wrong, please replace by a ASCII -

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3008

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2018

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpwvl0ai9y/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpwvl0ai9y/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4282).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-04"} .
Processing batch task - {"tag":"package-2018-05"} .
Failure during batch task - {"tag":"package-2018-05"} -- Error: [Exception] No input files provided.

Use --help to get help information..
[Exception] No input files provided.

Use --help to get help information.

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3240

@lmazuel
Copy link
Member

lmazuel commented Jul 26, 2018

@vladbarosan the script "momentOfTruthPostProcessing" is that you? This is failing saying the JSON is incorrect, but doesn't tell what JSON :/

SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at Object.<anonymous> (/home/travis/build/Azure/azure-rest-api-specs/scripts/momentOfTruthPostProcessing.js:68:21)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

@vladbarosan
Copy link

@lmazuel nope. Tag @sarangan12 and @bsiegel since they are the ones who touched this file.

@lmazuel
Copy link
Member

lmazuel commented Jul 26, 2018

@bsiegel @sarangan12 seems you're the only two contributor on this script. Please help :)

@lmazuel lmazuel merged commit b42dc7e into Azure:Network-August-Release Jul 26, 2018
@lmazuel
Copy link
Member

lmazuel commented Jul 26, 2018

Merging with broken linter to unlock Network team. Looking at the linter issue, this is pure in our utils, nothing to do with the PR.
I checkouted the PR on my machine and did:

  • A manual diff to check that only API version changed.
  • Check that VMSS files are still in their own api-version

That's enough for me to merge, based on the urgency of the PR.

anton-evseev pushed a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Jul 27, 2018
* Created folder for 2018-07-01 api version

* fixed incorrect encoding symbol
jianghaolu pushed a commit that referenced this pull request Aug 17, 2018
* Created folder for 2018-07-01 api version (#3509)

* Created folder for 2018-07-01 api version

* fixed incorrect encoding symbol

* Fix lint diff and improve output on failure (#3528)

Lint diff was failing on PRs with a base branch other than master. We
needed to fetch the base branch ref from the origin before trying to
resolve it to its commit hash.

* Python conf for Network 2018-06 (#3535)

* Py conf for Network 2018-07-01 (#3539)

* Introduce Publicipprefix to swagger (#3520)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Publicipprefixaugust (#3573)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Service Endpoint Policies Swagger (#3558)

* Service Endpoint Policies Swagger

* Fix review comments

* Updated Network Usage location parameter pattern (#3583)

* Add enableTcpReset property to load balancer (#3545)

* Add enableTcpReset property to load balancer.

* Update loadbalancer examples with enableTcpReset.

* added global reach flag (#3542)

* fix query packet capture status in latest version (#3601)

* Publicipprefixaugust (#3618)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Publicipprefixaugust (#3631)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties

* Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647)

Description of Changes:
    - Added a flag expressRouteGatewayBypass to the Connection
      Properties.
    - The user can set the flag to True to use MSEEv2 datapath

Related work items: #2628003

* Added new API to networkwatcher.json and examples (#3650)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655)

* Add/Edit Outbound Rule on Load Balancer and Examples (#3592)

* Add/Edit Outbound Rule on Load Balancer and Examples

* Adding properties enabletcpreset, idletimeoutinminutes and protocol

* Adding a reference to Public IP Prefix

* Dummy Commit

* Removed QueryConnectionMOnitors API (#3661)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* removed QueryConnectionMonitors Api
@MikhailTryakhov MikhailTryakhov deleted the 07-01-network branch September 14, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants