Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Usages' validation to allow display names like "West US" #3583

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix Usages' validation to allow display names like "West US" #3583

merged 1 commit into from
Aug 6, 2018

Conversation

anton-evseev
Copy link
Contributor

This fix was previously merged but somehow got lost between branches #1811
Fixes #3581

Allow spaces in location in Usages_List

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from dsgouda August 6, 2018 11:26
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 6, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Aug 6, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 6, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3080

@AutorestCI AutorestCI mentioned this pull request Aug 6, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 6, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpsv5v6rf_/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpsv5v6rf_/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.79)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

@AutorestCI
Copy link

AutorestCI commented Aug 6, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Aug 6, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

dsgouda
dsgouda approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 984fe8d into Azure:Network-August-Release Aug 6, 2018
@anton-evseev anton-evseev mentioned this pull request Aug 6, 2018
Closed
jianghaolu pushed a commit that referenced this pull request Aug 17, 2018
@MikhailTryakhov @jianghaolu
Azure Network August release (#3635)
c9d1315 
* Created folder for 2018-07-01 api version (#3509)

* Created folder for 2018-07-01 api version

* fixed incorrect encoding symbol

* Fix lint diff and improve output on failure (#3528)

Lint diff was failing on PRs with a base branch other than master. We
needed to fetch the base branch ref from the origin before trying to
resolve it to its commit hash.

* Python conf for Network 2018-06 (#3535)

* Py conf for Network 2018-07-01 (#3539)

* Introduce Publicipprefix to swagger (#3520)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Publicipprefixaugust (#3573)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Service Endpoint Policies Swagger (#3558)

* Service Endpoint Policies Swagger

* Fix review comments

* Updated Network Usage location parameter pattern (#3583)

* Add enableTcpReset property to load balancer (#3545)

* Add enableTcpReset property to load balancer.

* Update loadbalancer examples with enableTcpReset.

* added global reach flag (#3542)

* fix query packet capture status in latest version (#3601)

* Publicipprefixaugust (#3618)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Publicipprefixaugust (#3631)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties

* Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647)

Description of Changes:
    - Added a flag expressRouteGatewayBypass to the Connection
      Properties.
    - The user can set the flag to True to use MSEEv2 datapath

Related work items: #2628003

* Added new API to networkwatcher.json and examples (#3650)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655)

* Add/Edit Outbound Rule on Load Balancer and Examples (#3592)

* Add/Edit Outbound Rule on Load Balancer and Examples

* Adding properties enabletcpreset, idletimeoutinminutes and protocol

* Adding a reference to Public IP Prefix

* Dummy Commit

* Removed QueryConnectionMOnitors API (#3661)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* removed QueryConnectionMonitors Api
@anton-evseev anton-evseev deleted the usage-pattern-fix branch September 21, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anton-evseev @azuresdkci @AutorestCI @dsgouda @EvgenyAgafonchikov