Add enableTcpReset property to load balancer

[dumahesh-msft]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_Network-August-Release
  stderr: 'To https://github.com/Azure/azure-sdk-for-python.git
 ! [rejected]            restapi_auto_Network-August-Release -> restapi_auto_Network-August-Release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-python.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

[AutorestCI]

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3262

[lmazuel]

LGTM, but could you update one of the examples with this new field? Thanks,

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpobux2_3j/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpobux2_3j/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.71', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.71->2.1.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
Shutting Down
FATAL: java/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Failure during batch task - {"tag":"package-2018-06"} -- false.

[lmazuel]

@ravbhatnagar for review too

[dumahesh-msft]

Updated examples with the new property.

[jhendrixMSFT]

@AutorestCI regenerate azure-sdk-for-go

[ravbhatnagar]

Adding a settable property to existing stable API-version can result in unintentional behavior for the customers. Say this property was set using portal or template, and then someone using the older version of the SDK GETs the resource. This property will be ignored by the client since it did not understand it. Now the PUT comes on this resource which does not have this property in the request body. What happens to the state of this property on the server?

[lmazuel]

@ravbhatnagar This API is not in prod yet (note the base branch is a work-in-progress branch).
However, I remember seeing you discussing about boolean properties, it was mostly why I wanted to see what you think.

[dumahesh-msft]

@ravbhatnagar Like @lmazuel mentioned, this API is not prod yet. I'm adding a new property to the next API that will be published.

[ravbhatnagar]

Signing off! @dumahesh-msft - Bools are typicaly not recommended since they are not vry descriptive and does not allow for future expansion of states that can be supported. A string enum works better in most cases. Something for you to consider.

[dumahesh-msft]

Thanks @ravbhatnagar! Will definitely keep it in mind for the future.