Introduce Publicipprefix to swagger #3520

anilingle-ms · 2018-07-26T23:35:11Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-26T23:35:52Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2347

AutorestCI · 2018-07-26T23:41:01Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-26T23:43:15Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3037

AutorestCI · 2018-07-26T23:45:39Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2286

AutorestCI · 2018-07-26T23:52:46Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3248

…urceModel

anavinahar · 2018-07-27T23:17:43Z

...network/resource-manager/Microsoft.Network/stable/2018-07-01/examples/PublicIpPrefixGet.json

+            "provisioningState" : "Succeeded",
+            "publicIPAddressVersion" : "IPv4",
+            "idleTimeoutInMinutes" : 4,
+            "ipTags" : [


We're exposing tags as part of the prefix?

Also, should it align with this: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2018-06-01/examples/PublicIpAddressList.json

lmazuel

Change ApiVersion, otherwise LGTM. Need ARM feedback.

lmazuel · 2018-07-30T16:59:53Z

specification/network/resource-manager/Microsoft.Network/stable/2018-07-01/publicIpPrefix.json

+    "info": {
+      "title": "NetworkManagementClient",
+      "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
+      "version": "2018-06-01"


Incorrect API version

azuresdkci · 2018-07-30T17:45:40Z

Can one of the admins verify this patch?

…s/azure-rest-api-specs into publicipprefixaugust

anilingle-ms · 2018-07-30T18:08:57Z

Fixed. Please Re-Review if needed.

lmazuel · 2018-07-30T21:45:21Z

@anilingle-ms Actually, your example does not pass validation:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/410049638

Example, some examples contains publicIPAllocationMethod that are not defined in the Swagger. Either add these to the Swagger if they are expected/returned by the server, or remove them from examples.

lmazuel

Examples validation error.

…s/azure-rest-api-specs into publicipprefixaugust

lmazuel · 2018-07-31T16:18:19Z

@ravbhatnagar could you check everything is fine fro; an ARM point of view? All PR is passing CI now. Thanks!

ravbhatnagar · 2018-07-31T17:11:13Z

This has been reviewed.

* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

…ce-manager-schemas Remove azure-resource-manager-schemas

anilingle-ms requested review from DeepakRajendranMsft and MikhailTryakhov as code owners July 26, 2018 23:35

AutorestCI mentioned this pull request Jul 26, 2018

[AutoPR network/resource-manager] Introduce Publicipprefix to swagger Azure/azure-sdk-for-node#3248

Merged

anton-evseev mentioned this pull request Jul 27, 2018

Cherry pick fix for linter into "Network-August-Release" #3528

Merged

10 tasks

Anil Ingle added 9 commits July 27, 2018 14:53

Add PublicIpPrefix

4769c53

Add PublicIpPrefix

72c7442

Add PublicIpPrefix

a8295b3

Move to 2018-07-01 branch

7792309

revertversionchange

c8d437b

Fix Syntax error

e951857

Fix IpTag description because evidently everything is global

37568d3

Fix $ref for PublicIpPrefix

bab987d

Fix Casing

37bd243

anilingle-ms force-pushed the publicipprefixaugust branch from ed51c3c to 37bd243 Compare July 27, 2018 21:54

Add Exception for PublicIPPrefix from RequiredPropertiesMissingInReso…

03908b1

…urceModel

anavinahar reviewed Jul 27, 2018

View reviewed changes

lmazuel self-assigned this Jul 28, 2018

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2018

anavinahar approved these changes Jul 28, 2018

View reviewed changes

lmazuel requested changes Jul 30, 2018

View reviewed changes

Merge branch 'Network-August-Release' into publicipprefixaugust

996a9be

Anil Ingle added 2 commits July 30, 2018 11:05

Fix Version#

3c8b51d

Merge branch 'publicipprefixaugust' of https://github.com/anilingle-m…

bb8115c

…s/azure-rest-api-specs into publicipprefixaugust

AutorestCI mentioned this pull request Jul 30, 2018

[AutoPR network/resource-manager] Introduce Publicipprefix to swagger Azure/azure-sdk-for-python#3037

Closed

lmazuel approved these changes Jul 30, 2018

View reviewed changes

Merge branch 'Network-August-Release' into publicipprefixaugust

36933bb

lmazuel requested changes Jul 30, 2018

View reviewed changes

Anil Ingle added 2 commits July 30, 2018 15:28

Fix Examples

0fe47bf

Merge branch 'publicipprefixaugust' of https://github.com/anilingle-m…

a340246

…s/azure-rest-api-specs into publicipprefixaugust

This was referenced Jul 30, 2018

[AutoPR network/resource-manager] Introduce Publicipprefix to swagger Azure/azure-sdk-for-java#2286

Merged

[AutoPR network/resource-manager] Introduce Publicipprefix to swagger Azure/azure-sdk-for-go#2347

Merged

lmazuel approved these changes Jul 31, 2018

View reviewed changes

ravbhatnagar added App Services ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2018

lmazuel added Network and removed App Services labels Jul 31, 2018

lmazuel merged commit 3dab8a0 into Azure:Network-August-Release Jul 31, 2018

anton-evseev mentioned this pull request Sep 13, 2019

PublicIpPrefix: add parameters PublicIpAddressVersion and IpTags Azure/azure-cli#10527

Closed

danieljurek added a commit that referenced this pull request Oct 15, 2024

Merge pull request #3520 from danieljurek/djurek/test-removing-resour…

8df52d6

…ce-manager-schemas Remove azure-resource-manager-schemas

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Publicipprefix to swagger #3520

Introduce Publicipprefix to swagger #3520

anilingle-ms commented Jul 26, 2018

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

anavinahar Jul 27, 2018

lmazuel left a comment

lmazuel Jul 30, 2018

azuresdkci commented Jul 30, 2018

anilingle-ms commented Jul 30, 2018 via email •

edited by lmazuel

Loading

lmazuel commented Jul 30, 2018

lmazuel left a comment

lmazuel commented Jul 31, 2018

ravbhatnagar commented Jul 31, 2018

Introduce Publicipprefix to swagger #3520

Introduce Publicipprefix to swagger #3520

Conversation

anilingle-ms commented Jul 26, 2018

PR information

Quality of Swagger

AutorestCI commented Jul 26, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 26, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 26, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 26, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 26, 2018 • edited Loading

Automation for azure-sdk-for-node

anavinahar Jul 27, 2018

Choose a reason for hiding this comment

lmazuel left a comment

Choose a reason for hiding this comment

lmazuel Jul 30, 2018

Choose a reason for hiding this comment

azuresdkci commented Jul 30, 2018

anilingle-ms commented Jul 30, 2018 via email • edited by lmazuel Loading

lmazuel commented Jul 30, 2018

lmazuel left a comment

Choose a reason for hiding this comment

lmazuel commented Jul 31, 2018

ravbhatnagar commented Jul 31, 2018

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

anilingle-ms commented Jul 30, 2018 via email •

edited by lmazuel

Loading