Fix farmer rewards checks and add observer tests #11147

emlowe · 2022-04-13T01:14:31Z

The GUI farmer rewards check was not checking for observer keys and the code was duplicated from farmer and wallet, which is one reason this was missed.

Consolidated some code into new function called by both the wallet and farmer and added tests for observer keys.

Also added the ability to pass in the number of derivations to the RPC call - primarily this was so the tests can pass in much smaller numbers than the default (500) and so the tests can run much faster. However, this flexibility seems worth while regardless

xdustinface

I will review tomorrow but one thing i noticed as i skimmed it: I think you should drop all those unrelated isort changes.. imo we shouldn't just mix those into other PRs to have clear scopes why things have changed.

chia/farmer/farmer.py

chia/wallet/derive_keys.py

paninaro

lgtm

This reverts commit db536c6.

* Mark the github workspace as safe * Move the git config step after git is installed in the test containers

…ex, but caching puzzle_hash -> secret key (which is the lookup we're actually interested in). This avoids duplicating the actual derivation (#11154)

…re-releases that could be returned by listReleases (#11165)

* Build cli only version of debs * Export the vars needed by j2 * Fix paths * Add symlink to chia in /usr/local/bin/ * Upload the cli only debs to s3 * Add init.py * Ensure SHA is on the dev build for amd64

…11146)

…lso add feature keep_going_until_tx_block. (#11185)

* Correct wallet CLI sent/received indication * extract dict to reusable global scope, plus a function

Retry to load the pool info with a 2 minutes interval if it failed.

* Optimize test_wallet_sync * Update tests/wallet/sync/test_wallet_sync.py Co-authored-by: Kyle Altendorf <sda@fstab.net> * Fix test Co-authored-by: Kyle Altendorf <sda@fstab.net>

Recent runs are mostly low 30s but some are close to 40 and one just timed out.

* Remove logging tweak for no-longer-used websockets library Follow up after #10611. * Update pylintrc * Update test_daemon.py

…on status (#11133)

* Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Also update runner_templates * Mark the github workspace as safe (#11159) * Mark the github workspace as safe * Move the git config step after git is installed in the test containers Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com> Co-authored-by: Chris Marslender <chrismarslender@gmail.com>

* Set `in_transaction` for `set_finished_sync_up_to` * Call `clean_block_records` based on `in_transaction` * Don't pop wallets in `reorg_rollback`, do it after it was commited

* optimize Program.curry() * Add a comment for this curry implementation * optimize Program.curry() * Add comment Co-authored-by: arty <art.yerkes@gmail.com>

#11204)

And replace with just 3.9.x

* avoid serialisation in logging * avoid serialisation in logging * Revert "avoid serialisation in logging" This reverts commit 4a2b447.

* Add cli only rpm * Ensure rvm (fpm) is loaded before running fpm * Use full path to fpm, since GHA seems to mess up the PATH in the container * Add back source and add use ruby-3 * Call rpm script with bash, to see if the rvm script works * Add --depends for libcrypt.so.1

Fix farmer rewards checks and add observer tests

01c1e47

emlowe requested review from paninaro and xdustinface April 13, 2022 01:14

xdustinface suggested changes Apr 13, 2022

View reviewed changes