This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Update VM to match C# + Add JSON VM Test support #921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into CityOfZion/development
…into CityOfZion/development
…into CityOfZion/development
…into CityOfZion/development
…into CityOfZion/development * 'development' of https://github.com/CityOfZion/neo-python: Bump version: 0.8.4-dev → 0.8.5-dev Updated changelog for release
…into CityOfZion/development
…into CityOfZion/development * 'development' of https://github.com/CityOfZion/neo-python: Prove "getbalance" RPC method (#906) Improve usage of neo-python CLI (#907)
* Add wallet height to bottom toolbar * update changelog * Add wallet height to bottom toolbar * change wallet height increment logic
* Fixed size calculation for RegisterTransaction * Updated CHANGELOG.rst
* commit '8a08b0de8fcb153a92161d986f2ccc4158649b07': Support #888 (#911) Fixed size calculation for RegisterTransaction (#916) Add wallet height to bottom toolbar (#912) Enhance 'wallet' cmd output (#909) remove bitcoin imported function (will be removed from neocore) (#910) # Conflicts: # CHANGELOG.rst # neo/VM/ExecutionEngine.py
jseagrave21
reviewed
Mar 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is massive! 💪 Great work!
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
This brings the VM up to date with the following PR's:
neo-project/neo#601
neo-project/neo-vm#75
neo-project/neo-vm#84
neo-project/neo-vm#87
neo-project/neo-vm#90
also add supports for running the official C# tests for the
ExecutionEngine
How did you solve this problem?
update code
How did you make sure your solution works?
make test
and test against JSON test cases of the C#neo-vm
Are there any special changes in the code that we should be aware of?
too many
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)