Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDT: Create identity group configuration file. #4

Closed
Bubbus opened this issue Nov 30, 2020 · 0 comments · Fixed by #8
Closed

IDT: Create identity group configuration file. #4

Bubbus opened this issue Nov 30, 2020 · 0 comments · Fixed by #8

Comments

@Bubbus
Copy link
Collaborator

Bubbus commented Nov 30, 2020

A config file should be made which allows us to define faces and speakers for each identity-group. My initial take is that we can use a structure similar to the gearscript files, eg:

_speakers = ["voice1", "voice2", ...];
_faces = ["face1", ...];

CREATE_IDENTITY(csat,_speakers,_faces);

If you think of a simpler config schema then go for it. the focus is on making it hard for a newbie to screw up, so the ideal config schema is easily copy/pasteable and it should be obvious which parts need to be edited.

If you're up for it then make a new identity_macros.hpp file and fill in whatever you need to make this config file work. Use gearscript_macros.hpp as reference for the macro stuff. If you want to avoid macros for now then use the config to assign these identities to global variables like f_var_identity_csat and we can abstract that part away from the end-user after the fact.

@Bubbus Bubbus added this to the Identity translation module milestone Nov 30, 2020
@Bubbus Bubbus changed the title Create identity group configuration file. IDT: Create identity group configuration file. Nov 30, 2020
@dgibso29 dgibso29 self-assigned this Dec 1, 2020
dgibso29 added a commit to dgibso29/F3_CA_BUB that referenced this issue Dec 2, 2020
…ing#2 90%  complete.

Resolves CombinedArmsGaming#3 resolves CombinedArmsGaming#4 resolves CombinedArmsGaming#5 resolves CombinedArmsGaming#6

Still need to handle if no identity is assigned and do MP test.
@dgibso29 dgibso29 linked a pull request Dec 3, 2020 that will close this issue
@Bubbus Bubbus closed this as completed in #8 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants