Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDT: Main ticket #2

Closed
Bubbus opened this issue Nov 30, 2020 · 0 comments · Fixed by #8
Closed

IDT: Main ticket #2

Bubbus opened this issue Nov 30, 2020 · 0 comments · Fixed by #8
Assignees
@dgibso29
Labels
identity translation
Milestone
Identity translat...

Comments

@Bubbus
Copy link
Collaborator

Bubbus commented Nov 30, 2020

  • All work to be done in branch identity-translation.

  • Complete all tickets in milestone then QA.

  • Prioritise readability over performance - this project avoids spaghetti as much as SQF will allow.

  • Short functions preferred over long imperative sprawl.

  • Comments not needed if code per file is short and self-documenting.

  • All functional code to be located in folder components\identity.

  • All configuration to be located in appropriately named files/folders within folder configuration.

  • Any config code needed in description.ext to be appropriately named, complex logic to be split out into functions.
@Bubbus Bubbus mentioned this issue Nov 30, 2020
Closed
@Bubbus Bubbus added this to the Identity translation module milestone Nov 30, 2020
@dgibso29 dgibso29 self-assigned this Dec 1, 2020
dgibso29 added a commit to dgibso29/F3_CA_BUB that referenced this issue Dec 2, 2020
@dgibso29
Working identity translation and initial definitions. CombinedArmsGam…
ad3e080 
…ing#2 90%  complete.

Resolves CombinedArmsGaming#3 resolves CombinedArmsGaming#4 resolves CombinedArmsGaming#5 resolves CombinedArmsGaming#6

Still need to handle if no identity is assigned and do MP test.
dgibso29 added a commit to dgibso29/F3_CA_BUB that referenced this issue Dec 3, 2020
@dgibso29
CombinedArmsGaming#2 Misc fixes, added documentation for Identity Tra…
41a7579 
…nslation config files
@dgibso29 dgibso29 mentioned this issue Dec 3, 2020
Merged
@Bubbus Bubbus closed this as completed in #8 Dec 5, 2020
@dgibso29 dgibso29 mentioned this issue Apr 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgibso29 dgibso29

Labels
identity translation
Projects
None yet
Milestone
Identity translation module
Development

Successfully merging a pull request may close this issue.

Merge Identity translation dgibso29/F3_CA_BUB
2 participants
@Bubbus @dgibso29