Skip to content

Conversation

@brettlangdon
Copy link
Member

Description

They are failing with:

AttributeError: 'OverheadControl' object has no attribute 'release_request'

Which means we aren't getting benchmark results, and now the SLO check will fail if the results for a given benchmark are missing.

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested review from a team as code owners November 14, 2025 17:53
@brettlangdon brettlangdon added changelog/no-changelog A changelog entry is not required for this PR. backport 4.0 backport 3.19 labels Nov 14, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml         @DataDog/python-guild @DataDog/apm-core-python
.gitlab/benchmarks/microbenchmarks.yml                                  @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) November 14, 2025 18:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 249 ± 4 ms.

The average import time from base is: 255 ± 4 ms.

The import time difference between this PR and base is: -5.6 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 6.598 ms (2.65%)
ddtrace.bootstrap.sitecustomize 3.892 ms (1.56%)
ddtrace.bootstrap.preload 3.892 ms (1.56%)
ddtrace.internal.settings.dynamic_instrumentation 0.675 ms (0.27%)
ddtrace.internal.remoteconfig.worker 0.659 ms (0.26%)
ddtrace.internal.remoteconfig.client 0.601 ms (0.24%)
ddtrace 2.706 ms (1.09%)
ddtrace.trace 0.677 ms (0.27%)
ddtrace._logger 0.672 ms (0.27%)
ddtrace.internal.telemetry 0.672 ms (0.27%)
ddtrace.internal.telemetry.writer 0.672 ms (0.27%)
ddtrace.internal.utils.version 0.672 ms (0.27%)
ddtrace.internal._unpatched 0.028 ms (0.01%)
json 0.028 ms (0.01%)
json.decoder 0.028 ms (0.01%)
re 0.028 ms (0.01%)
enum 0.028 ms (0.01%)
types 0.028 ms (0.01%)

@emmettbutler
Copy link
Collaborator

force-merging because appsec_iast_propagation is successfully removed from the list of benchmarks in gitlab https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/82491719

@emmettbutler emmettbutler merged commit 52d499b into main Nov 14, 2025
606 of 641 checks passed
@emmettbutler emmettbutler deleted the brettlangdon/disable.iast_propagation.benchmarks branch November 14, 2025 18:23
dd-octo-sts bot pushed a commit that referenced this pull request Nov 14, 2025
## Description

They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 52d499b)
@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Nov 14, 2025

The backport to 3.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.19 3.19
# Navigate to the new working tree
cd .worktrees/backport-3.19
# Create a new branch
git switch --create backport-15279-to-3.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 52d499bb14991d5d9edaa1dae0db0956ef9d8a4d
# Push it to GitHub
git push --set-upstream origin backport-15279-to-3.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.19

Then, create a pull request where the base branch is 3.19 and the compare/head branch is backport-15279-to-3.19.

emmettbutler added a commit that referenced this pull request Nov 14, 2025
## Description

They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 52d499b)
emmettbutler added a commit that referenced this pull request Nov 14, 2025
## Description

They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 52d499b)
emmettbutler added a commit that referenced this pull request Nov 14, 2025
Backport 52d499b from #15279 to 4.0.

## Description

They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
@juanjux
Copy link
Collaborator

juanjux commented Nov 17, 2025

cc @avara1986

emmettbutler added a commit that referenced this pull request Nov 17, 2025
They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

<!-- Describe your testing strategy or note what tests are included -->

<!-- Note any risks associated with this change, or "None" if no risks
-->

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 52d499b)
avara1986 added a commit that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.19 backport 4.0 changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants