Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER #3763

Merged
merged 11 commits into from
Oct 21, 2024
Merged

Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER #3763

merged 11 commits into from
Oct 21, 2024

Conversation

max-anu
Copy link
Contributor

@max-anu max-anu commented Oct 4, 2024 •
edited by rbeucher
Loading

Description

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

To help with the number of pull requests:

@max-anu max-anu requested a review from a team as a code owner October 4, 2024 01:11
@max-anu
Copy link
Contributor Author

max-anu commented Oct 4, 2024

@rbeucher @flicj191 Could one/both of you please look over this?

@rbeucher rbeucher changed the title Adding pr, tauu, tauv for NOAA-CIRES-20CR-V2 Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER Oct 4, 2024
@rbeucher
Copy link
Contributor

rbeucher commented Oct 4, 2024

@flicj191 can you have a look please?

@rbeucher rbeucher closed this Oct 4, 2024
@rbeucher rbeucher reopened this Oct 4, 2024
@rbeucher rbeucher assigned rbeucher and flicj191 and unassigned rbeucher Oct 4, 2024
flicj191
flicj191 requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@flicj191 flicj191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-anu, it looks to be working well,
Can you have a look at the Codacy/CI tests? it looks like the downloader script needs an empty line at the end of it,
not sure why its not building the docs but I've suggested cleaning the whitespace in the table to make the file formatted cleaner
I would also add the filenames in the formatter script description string (esmvaltool/cmorizers/data/formatters/datasets/noaa_cires_20cr_v2.py) to complete it
Cheers

doc/sphinx/source/input.rst Outdated Show resolved Hide resolved
max-anu and others added 3 commits October 9, 2024 09:49
@max-anu @flicj191
Table must have constant width
8e9bc48 
Co-authored-by: Felicity Chun <32269066+flicj191@users.noreply.github.com>
new line required at end of file
2bada4d
@max-anu
Merge branch 'main' into fix_190
9a43e1f
@flicj191
Copy link
Contributor

flicj191 commented Oct 9, 2024 •
edited
Loading

Sanity checking values:

global and annual means for *pr*

image

and annual means for extended ENSO region *pr* looks good

image

*tauv* for extended ENSO region

image

tauu need to check the direction/positive attribute @max-anu:
image

@rbeucher
Copy link
Contributor

rbeucher commented Oct 9, 2024

Thanks @flicj191 !

@max-anu
Copy link
Contributor Author

max-anu commented Oct 14, 2024 •
edited
Loading

tauu and tauv have both been flipped. I believe this is everything which needs to be done.
These graphs are over the enso region.
noaa-cires-20cr-v2

@rbeucher
Copy link
Contributor

OK @flicj191 can you do a last pass and merge please?

@flicj191 flicj191 self-requested a review October 15, 2024 06:12
flicj191
flicj191 requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@flicj191 flicj191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as the comment for the make negative, i'll try to look into the fail build

esmvaltool/cmorizers/data/formatters/datasets/ncep_ncar_r1.py Outdated Show resolved Hide resolved
@max-anu max-anu mentioned this pull request Oct 16, 2024
Merged
11 tasks
@flicj191
Copy link
Contributor

Document build fail is this: #3762
@rbeucher I'm not able to merge

@rbeucher
Copy link
Contributor

Data needs to be added to Levante first.

@flicj191
Copy link
Contributor

flicj191 commented Oct 17, 2024 •
edited
Loading

Raw data and CMORised data has been copied to DKRZ: /work/bd0854/DATA/ESMValTool2/RAWOBS & /work/bd0854/DATA/ESMValTool2/OBS/

@rbeucher rbeucher merged commit 5009b47 into ESMValGroup:main Oct 21, 2024
3 of 6 checks passed
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch 'main' into recipe_test_workflow_prototype
09490de 
* main: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMVal…
90c8ca1 
…Tool into 3723_remove_rose_cylc

* '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flicj191 flicj191 flicj191 approved these changes

@rbeucher rbeucher rbeucher approved these changes

Assignees

@flicj191 flicj191

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Variables (Pr, tos (Omon), tauu, tauv) to NOAA_CIRES-20CRV2 CMORISer in ESMValCore
3 participants
@max-anu @rbeucher @flicj191