Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readthedocs configuration/builds: revert to miniconda before miniforge is available #3785

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Readthedocs configuration/builds: revert to miniconda before miniforge is available #3785

merged 14 commits into from
Oct 22, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 18, 2024 •
edited
Loading

Description

Related to #3779 - while RTD implement and make miniforge3 available, we should use something else other than mambaforge to avoid the increasingly frequent "brownouts".

Docs with expected failure from the config changes https://readthedocs.org/projects/esmvaltool/builds/26029832/

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@bouweandela
Copy link
Member

The documentation build is failing. Is this ready for review?

@valeriupredoi
Copy link
Contributor Author

nope, I need to reinstate that silly metadata package again - this all feels like going backwards, unless we have other options (that I can't think of)?

@valeriupredoi valeriupredoi mentioned this pull request Oct 21, 2024
Merged
4 tasks
@bouweandela
Copy link
Member

Solving the environment with this setup takes about 350 seconds (miniconda-latest), while with the current main branch (mambaforge-22.9) it takes about 600 seconds. How about deleting all the commented-out stuff, merging this, and forgetting about miniforge3? Or would you expect further improvements from that?

From this blog post, it looks like mamba is already the default solver for conda: https://www.anaconda.com/blog/a-faster-conda-for-a-growing-community

@valeriupredoi
Copy link
Contributor Author

That'd what I thought too about mamba, but polling the RTD env for mamba returns executable not found - perhaps the mamba solver is used, but not the package with its executable? At any rate, I'd like to see what miniforge3 can do for us, that's why I'd leave all those comments in? Cheers buds 🍺

@bouweandela
Copy link
Member

Would it work for you to move the commented out stuff to an issue instead? Leaving commented out stuff lying around really makes a mess and will only confuse future maintainers (probably ourselves..)

@bouweandela
Copy link
Member

perhaps the mamba solver is used, but not the package with its executable?

That sounds plausible

@bouweandela
Copy link
Member

This link seems to confirm that: https://github.com/conda-incubator/setup-miniconda?tab=readme-ov-file#example-6-mamba

@valeriupredoi valeriupredoi mentioned this pull request Oct 22, 2024
Open
@valeriupredoi
Copy link
Contributor Author

@bouweandela I have just cleaned up the commented out bits in 2352ebc - a good call indeed to (temporarily, perhaps) remove all that guff 🍺

@valeriupredoi
Copy link
Contributor Author

I've also updated the OS to ubuntu-lts-latest as per https://docs.readthedocs.io/en/stable/config-file/v2.html#requirements-file - who'd have known I can update an OS, somewhere 😆

@bouweandela bouweandela merged commit c4b8d02 into main Oct 22, 2024
6 of 8 checks passed
@bouweandela bouweandela deleted the revert_to_miniconda_RTD branch October 22, 2024 15:08
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch 'main' into recipe_test_workflow_prototype
09490de 
* main: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMVal…
90c8ca1 
…Tool into 3723_remove_rose_cylc

* '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriupredoi @bouweandela