Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a CMORiser for CMAP data for pr #3766

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Adding a CMORiser for CMAP data for pr #3766

merged 5 commits into from
Oct 28, 2024

Conversation

max-anu
Copy link
Contributor

@max-anu max-anu commented Oct 9, 2024 •
edited
Loading

Description

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

To help with the number of pull requests:

@max-anu max-anu requested a review from a team as a code owner October 9, 2024 05:01
@rbeucher
Copy link
Contributor

Hi @flicj191, I think this one needs a closer look. The CMORiser needs to be added to the tests. Can you help @max-anu when you have a chance?

@max-anu
Copy link
Contributor Author

max-anu commented Oct 16, 2024

Values seem sensible:
comparison_CMAP

@max-anu
Copy link
Contributor Author

max-anu commented Oct 16, 2024

As far as I can tell, remaining errors are either not issues with the submitted code, or are expected (e.g. unused variables in function definition).

@flicj191
Copy link
Contributor

Hi @flicj191, I think this one needs a closer look. The CMORiser needs to be added to the tests. Can you help @max-anu when you have a chance?

@rbeucher, which tests do you mean?

@rbeucher
Copy link
Contributor

I thought there was a more extensive list of tests in tests/integration/test_cmorizer.py. Forget about that...

@flicj191 flicj191 changed the title Adding a CMORiser for CMAP data Adding a CMORiser for CMAP data for pr Oct 22, 2024
flicj191
flicj191 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@flicj191 flicj191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, runs, outputted sensible values. Though I can't copy files to Levante as I don't have permissions to create a folder. @ESMValGroup/obs-maintainers

@rbeucher
Copy link
Contributor

I can't see @max-anu in the list of authors: https://github.com/ESMValGroup/ESMValTool/blob/main/CITATION.cff
What about you @flicj191 ? Are you there?

@flicj191
Copy link
Contributor

What about you @flicj191 ? Are you there?

I added myself in the sea ice extents recipe PR #3607

@max-anu
Copy link
Contributor Author

max-anu commented Oct 25, 2024

I can't see @max-anu in the list of authors: https://github.com/ESMValGroup/ESMValTool/blob/main/CITATION.cff What about you @flicj191 ? Are you there?

I added myself as an author here: #3765

@rbeucher
Copy link
Contributor

RTD warnings are related to the change introduced in the ESMValTool configuration.

@rbeucher rbeucher merged commit f38bbf6 into ESMValGroup:main Oct 28, 2024
2 of 6 checks passed
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch 'main' into recipe_test_workflow_prototype
09490de 
* main: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMVal…
90c8ca1 
…Tool into 3723_remove_rose_cylc

* '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flicj191 flicj191 flicj191 approved these changes

Assignees

@flicj191 flicj191

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMORiser for CMAP 1979-2018 Data in ESMValCore
3 participants
@max-anu @rbeucher @flicj191