Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pr, tauu, tauv, tos to NCEP2 CMORISer #3765

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Adding pr, tauu, tauv, tos to NCEP2 CMORISer #3765

merged 7 commits into from
Oct 28, 2024

Conversation

max-anu
Copy link
Contributor

@max-anu max-anu commented Oct 9, 2024 •
edited by rbeucher
Loading

Description

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

To help with the number of pull requests:

@max-anu max-anu requested a review from a team as a code owner October 9, 2024 04:59
@rbeucher
Copy link
Contributor

@max-anu are you in the list of authors? If not you should be.

@max-anu
Copy link
Contributor Author

max-anu commented Oct 16, 2024

tauu and tauv are the negative of what they should be. Same issue as found in #3763. Changes will be made after this is added

comparison_NCEP-DOE-R2

@flicj191
Copy link
Contributor

#3763 has been merged, @max-anu can you please also check off as much of the checklist as you can, thanks, then I'll do another run through

@flicj191 flicj191 self-assigned this Oct 22, 2024
@max-anu
Copy link
Contributor Author

max-anu commented Oct 25, 2024

I believe this is now ready to commit.
Tauu/tauv are now the correct sign.
Note that I haven't moved any of the new OBS6 nc files across.

comparison_NCEP-DOE-R2

@max-anu max-anu mentioned this pull request Oct 25, 2024
Merged
11 tasks
@rbeucher rbeucher merged commit b86acb3 into ESMValGroup:main Oct 28, 2024
4 of 6 checks passed
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch 'main' into recipe_test_workflow_prototype
09490de 
* main: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
ehogan added a commit that referenced this pull request Nov 19, 2024
@ehogan
Merge branch '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMVal…
90c8ca1 
…Tool into 3723_remove_rose_cylc

* '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits)
  Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811)
  Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810)
  Remove recipe filler utility (#3777)
  [Condalock] Update Linux condalock file (#3809)
  change authors name (#3806)
  [Condalock] Update Linux condalock file (#3798)
  Fix contourf plots for masked data (#3797)
  [Condalock] Update Linux condalock file (#3796)
  Add next release schedule (#3794)
  Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789)
  Pin pys2index >=0.1.5 in osx environment (#3792)
  Adding a CMORiser for CMAP data for pr (#3766)
  Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765)
  Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785)
  Adapt ESMValTool to new configuration (#3761)
  Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763)
  update comment in conda lock creation Github action (#3788)
  [Condalock] Update Linux condalock file (#3786)
  update Docker builds badge in README (#3783)
  Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbeucher rbeucher rbeucher approved these changes

@flicj191 flicj191 Awaiting requested review from flicj191

Assignees

@flicj191 flicj191

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Variables (Pr, tos (Omon), tauu, tauv) to NCEP2 CMORISer in ESMValCore
3 participants
@max-anu @rbeucher @flicj191