Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier 2 software standards #595

Merged
merged 46 commits into from
Jul 16, 2024
Merged

Tier 2 software standards #595

merged 46 commits into from
Jul 16, 2024

Conversation

hover2pi
Copy link
Member

@hover2pi hover2pi commented May 7, 2024

This PR puts ExoCTK in compliance with the CSI tier 2 software standards.

mfixstsci and others added 30 commits January 26, 2024 10:54
update RTD config to use base conda environment and install from project metadata
Co-authored-by: Zach Burnett <zachary.r.burnett@gmail.com>
Remove Atmospheric Retrieval Support
add `CITATION.cff` from info in README
Tier2 Software Standards
@nespinoza
Copy link
Collaborator

@hover2pi will check this in test/dev, after those will report and then we can merge to main.

@hover2pi
Copy link
Member Author

hover2pi commented Jul 2, 2024

Lightcurve fitting wasn't completely removed. I moved that to #600 and will merge this separately. Test server looks good.

@hover2pi
Copy link
Member Author

hover2pi commented Jul 2, 2024

OK, ready to merge into main but technically needs a review.

@nespinoza nespinoza requested a review from mfixstsci July 2, 2024 15:53
@pep8speaks
Copy link

Hello @hover2pi, Thank you for updating !

Line 59:1: E265 block comment should start with '# '
Line 120:5: E123 closing bracket does not match indentation of opening bracket's line
Line 124:1: E265 block comment should start with '# '
Line 129:1: E265 block comment should start with '# '
Line 132:1: E265 block comment should start with '# '
Line 137:1: E265 block comment should start with '# '
Line 141:1: E265 block comment should start with '# '

Line 209:9: E265 block comment should start with '# '
Line 274:5: E265 block comment should start with '# '
Line 296:93: E226 missing whitespace around arithmetic operator

Line 39:46: E261 at least two spaces before inline comment
Line 42:1: E402 module level import not at top of file
Line 44:162: E231 missing whitespace after ':'
Line 45:164: E231 missing whitespace after ':'
Line 46:165: E231 missing whitespace after ':'
Line 56:1: E302 expected 2 blank lines, found 1
Line 128:32: E226 missing whitespace around arithmetic operator
Line 175:94: E231 missing whitespace after ','
Line 418:51: E261 at least two spaces before inline comment
Line 461:64: E261 at least two spaces before inline comment
Line 462:64: E261 at least two spaces before inline comment
Line 463:64: E261 at least two spaces before inline comment
Line 553:161: E241 multiple spaces after ','
Line 732:16: E261 at least two spaces before inline comment
Line 742:59: E226 missing whitespace around arithmetic operator
Line 1020:9: E303 too many blank lines (2)
Line 1082:18: E261 at least two spaces before inline comment
Line 1082:18: E262 inline comment should start with '# '

Line 20:1: E265 block comment should start with '# '
Line 391:1: W293 blank line contains whitespace
Line 754:21: W605 invalid escape sequence '('
Line 754:25: W605 invalid escape sequence ')'
Line 754:57: W605 invalid escape sequence '\c'
Line 754:74: W605 invalid escape sequence '\e'
Line 760:46: W605 invalid escape sequence '('
Line 760:48: W605 invalid escape sequence '\l'
Line 760:56: W605 invalid escape sequence '\m'
Line 760:66: W605 invalid escape sequence '\h'
Line 760:79: W605 invalid escape sequence '\m'
Line 760:85: W605 invalid escape sequence ')'
Line 761:46: W605 invalid escape sequence '('
Line 761:48: W605 invalid escape sequence '\l'
Line 761:56: W605 invalid escape sequence '\m'
Line 761:66: W605 invalid escape sequence '\h'
Line 761:79: W605 invalid escape sequence '\m'
Line 761:85: W605 invalid escape sequence ')'
Line 762:46: W605 invalid escape sequence '('
Line 762:48: W605 invalid escape sequence '\l'
Line 762:56: W605 invalid escape sequence '\m'
Line 762:66: W605 invalid escape sequence '\h'
Line 762:79: W605 invalid escape sequence '\m'
Line 762:85: W605 invalid escape sequence ')'
Line 768:58: W605 invalid escape sequence '('
Line 768:62: W605 invalid escape sequence '\m'
Line 768:69: W605 invalid escape sequence '\m'
Line 768:75: W605 invalid escape sequence ')'
Line 793:25: W605 invalid escape sequence '('
Line 793:29: W605 invalid escape sequence ')'
Line 793:61: W605 invalid escape sequence '\c'
Line 793:78: W605 invalid escape sequence '\e'
Line 799:50: W605 invalid escape sequence '('
Line 799:52: W605 invalid escape sequence '\l'
Line 799:60: W605 invalid escape sequence '\m'
Line 799:70: W605 invalid escape sequence '\h'
Line 799:83: W605 invalid escape sequence '\m'
Line 799:89: W605 invalid escape sequence ')'
Line 800:50: W605 invalid escape sequence '('
Line 800:52: W605 invalid escape sequence '\l'
Line 800:60: W605 invalid escape sequence '\m'
Line 800:70: W605 invalid escape sequence '\h'
Line 800:83: W605 invalid escape sequence '\m'
Line 800:89: W605 invalid escape sequence ')'
Line 801:50: W605 invalid escape sequence '('
Line 801:52: W605 invalid escape sequence '\l'
Line 801:60: W605 invalid escape sequence '\m'
Line 801:70: W605 invalid escape sequence '\h'
Line 801:83: W605 invalid escape sequence '\m'
Line 801:89: W605 invalid escape sequence ')'
Line 807:62: W605 invalid escape sequence '('
Line 807:66: W605 invalid escape sequence '\m'
Line 807:73: W605 invalid escape sequence '\m'
Line 807:79: W605 invalid escape sequence ')'

Line 86:1: E302 expected 2 blank lines, found 1

Line 6:2: W292 no newline at end of file

@hover2pi hover2pi merged commit fe7747e into main Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants