Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAAS now works with ExtData; maintenance and bug-fixes for TR, GMI and StratChem #241

Merged
merged 38 commits into from
Jan 5, 2023

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Jan 5, 2023

This PR is zero diff for PCHEM simulations.
It is zero-diff for GMI simulations, with 2 minor caveats:
The long_name attributes for GMI species have been restored, fixing a bug from v1.10.2
The diagnostics HNO3GASsad and HNO3CONDsad are now initialized to MAPL_UNDEF instead of 0.0; this does not change the results of the model.

Short list of changes:
GAAS now works with (only) ExtData2G (requires MAPL v2.32 or higher)
Added GMI diagnostic stOX_loss for use by TR
GitHub label enforcement is now done via GitHub actions
CircleCI updated to Baselibs 7.7.0
In GMI: cleaned up lbssad_opt and h2oclim_opt
In GMI: cleaned up exports HNO3GASsad, HNO3CONDsad and jNO2val
Fixed long_name attributes for all GMI and StratChem species.
Fixed the imports for LAI_FRAC and VEG_FRAC in TR and GMI, for simulations with vertical resolution other than 72.

bena-nasa and others added 30 commits November 22, 2022 09:52
…oss includes QQK and QQJ terms, and varies with the chem mechanism
new GMI export: stOX_loss,  used by TR
Due to changes at Heroku, we need to transition to use a GitHub Action for label enforcement. The current label enforcer no longer works, so PRs will be "stuck" until this is fixed.
…nforcer-chem

Move to use GitHub Action for Label Enforcement
…_opt_cleanup

Cleaned up lbssad_opt and h2oclim_opt
…val; now use only MAPL routines instead of GMI/ESMF wrappers.
mathomp4 and others added 8 commits January 3, 2023 15:53
Prepare for release on 1/4/23
… ungridded dim and set vlocation to none, this is model level independent
fix VEG & LAI imports, the 3rd dimension is not model levels, so need to use ungridded dimension
…ong_names

Fixed the long_names for StratChem chemical species
@mmanyin mmanyin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug labels Jan 5, 2023
@mmanyin mmanyin requested review from a team as code owners January 5, 2023 19:06
@mmanyin mmanyin merged commit 86ac1a6 into main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants