-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAAS now works with ExtData; maintenance and bug-fixes for TR, GMI and StratChem #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss includes QQK and QQJ terms, and varies with the chem mechanism
…e that did not exist
new GMI export: stOX_loss, used by TR
Due to changes at Heroku, we need to transition to use a GitHub Action for label enforcement. The current label enforcer no longer works, so PRs will be "stuck" until this is fixed.
…nforcer-chem Move to use GitHub Action for Label Enforcement
Update CircleCI to Baselibs 7.7.0
Fix GMI issue related to stOX_loss
…_opt_cleanup Cleaned up lbssad_opt and h2oclim_opt
…val; now use only MAPL routines instead of GMI/ESMF wrappers.
Prepare for release on 1/4/23
…gain Make GAAS work
… ungridded dim and set vlocation to none, this is model level independent
fix VEG & LAI imports, the 3rd dimension is not model levels, so need to use ungridded dimension
…ong_names Fixed the long_names for StratChem chemical species
mathomp4
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is zero diff for PCHEM simulations.
It is zero-diff for GMI simulations, with 2 minor caveats:
The long_name attributes for GMI species have been restored, fixing a bug from v1.10.2
The diagnostics HNO3GASsad and HNO3CONDsad are now initialized to MAPL_UNDEF instead of 0.0; this does not change the results of the model.
Short list of changes:
GAAS now works with (only) ExtData2G (requires MAPL v2.32 or higher)
Added GMI diagnostic stOX_loss for use by TR
GitHub label enforcement is now done via GitHub actions
CircleCI updated to Baselibs 7.7.0
In GMI: cleaned up lbssad_opt and h2oclim_opt
In GMI: cleaned up exports HNO3GASsad, HNO3CONDsad and jNO2val
Fixed long_name attributes for all GMI and StratChem species.
Fixed the imports for LAI_FRAC and VEG_FRAC in TR and GMI, for simulations with vertical resolution other than 72.