Generate UrlMap in Terraform. #545
Conversation
rileykarson
force-pushed
the
url-map-terraform
branch
2 times, most recently
from
274c975 to
f664406
Compare
rileykarson
force-pushed
the
url-map-terraform
branch
from
f664406 to
a9703d0
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Also @danawillow can you look over the docs changes to other providers as a sanity check as well? I don't want to collect new LGTMs for like +- 8 characters of text in each |
Instead of just deleting them from code
|
Docs changes to other providers LGTM, though I think you need to do another round of generation because this seems to have picked up some things that have already been merged. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 7be2954) have been included in your existing downstream PRs. |
|
I caught a missing Required - let me know if you think I should get LGTM's from the other providers. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 2399755) have been included in your existing downstream PRs. |
|
I think it's fine, though I'm confused why the puppet-google and chef-google changes are showing up in this PR and don't seem to be showing up in others. |
|
Those changes are actually already merged by the downsteams of Nathan's PR here, I'm not sure why they still show up as diffs - I can close out those PRs since they will no-op anyways. The Magician gets confused when a PR exists for a long time I guess. |
Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
Generate UrlMap in Terraform.
[all]
Minor docs changes for UrlMap
[terraform]
Autogenerate google_compute_url_map
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]