forked from apache/kvrocks
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] unstable from apache:unstable #83
Merged
Merged
+2,482
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
…er` (#2046) Co-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com> Co-authored-by: Twice <twice.mliu@gmail.com>
…2051) These following cases will crash the server, the reason is that the index of numkeys is wrong: ``` command getkeys zdiffstore dst 2 src1 src2 command getkeys zinterstore dst 2 src1 src2 command getkeys zunionstore dst 2 src1 src2 ``` These following getkeys output is wrong: ``` > command getkeys zdiff 2 key1 key2 1) "key1" 2) "key2" 3) (nil) > command getkeys bzmpop 0 2 key1 key2 1) "key1" ``` These are ok: ``` command getkeys zinter 2 key1 key2 command getkeys zunion 2 key1 key2 command getkeys sintercard 2 key1 key2 command getkeys zintercard 2 key1 key2 command getkeys zmpop 2 key1 key2 command getkeys lmpop 2 key1 key2 command getkeys blmpop 0 2 key1 key2 ``` However, at present, there is still a problem with our zset store. We do not support returning dst key, but let's do it later... ``` 127.0.0.1:6379> command getkeys zinterstore dst 2 src1 src2 1) "dst" 2) "src1" 3) "src2" 127.0.0.1:6666> command getkeys zinterstore dst 2 src1 src2 1) "src1" 2) "src2" ```
Co-authored-by: hulk <hulk.website@gmail.com>
We should output empty instead of `null` as PR number for unstable branch.
Implement the unified WAL iterator for kvrocks, similar to the DBIterator. It will wrap rocksdb WAL Iterator and can return different item types. It is possible to implement their processing logic depending on the concrete type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )