Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] unstable from apache:unstable #83

Merged
merged 20 commits into from
Jan 29, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 28, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

jihuayu and others added 20 commits January 22, 2024 15:07
Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
…er` (#2046)

Co-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: Twice <twice.mliu@gmail.com>
…2051)

These following cases will crash the server, the reason is that
the index of numkeys is wrong:
```
command getkeys zdiffstore dst 2 src1 src2
command getkeys zinterstore dst 2 src1 src2
command getkeys zunionstore dst 2 src1 src2
```

These following getkeys output is wrong:
```
> command getkeys zdiff 2 key1 key2
1) "key1"
2) "key2"
3) (nil)

> command getkeys bzmpop 0 2 key1 key2
1) "key1"
```

These are ok:
```
command getkeys zinter 2 key1 key2
command getkeys zunion 2 key1 key2
command getkeys sintercard 2 key1 key2
command getkeys zintercard 2 key1 key2
command getkeys zmpop 2 key1 key2
command getkeys lmpop 2 key1 key2
command getkeys blmpop 0 2 key1 key2
```

However, at present, there is still a problem with our zset store.
We do not support returning dst key, but let's do it later...
```
127.0.0.1:6379> command getkeys zinterstore dst 2 src1 src2
1) "dst"
2) "src1"
3) "src2"

127.0.0.1:6666> command getkeys zinterstore dst 2 src1 src2
1) "src1"
2) "src2"
```
Co-authored-by: hulk <hulk.website@gmail.com>
We should output empty instead of `null` as PR number for unstable branch.
Implement the unified WAL iterator for kvrocks, similar to the DBIterator.
It will wrap rocksdb WAL Iterator and can return different item types.
It is possible to implement their processing logic depending on the concrete type.
@pull pull bot added the ⤵️ pull label Jan 28, 2024
@pull pull bot merged commit 892ea91 into JoverZhang:unstable Jan 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants