-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/live 2987/rtl arabic support #1369
Conversation
Setup for RTL in iOS and Android configuration files.
β¦chingLang Feat/live 3369/restart when switching lang
New modal to confirm language change + updated icons generation to suβ¦
LIVE-2987 - Carousel RTL compat
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 5d31626 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 0.00% // Head: 44.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
============================================
+ Coverage 0 44.95% +44.95%
============================================
Files 0 633 +633
Lines 0 26696 +26696
Branches 0 7229 +7229
============================================
+ Hits 0 12000 +12000
- Misses 0 14645 +14645
- Partials 0 51 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general comment: the usage of .svg in our app has grown and it could cause performance problem. it's generally recommended to use images (x1, x2, x3) on mobile for performance.
i let other devs review this PR π
β¦IVE-2987/RTL-arabic-support # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
β¦nt issues in RTL mode. Modified arabic language name
β¦an english word
FYI this PR have conflicts @mlegall-ledger |
Fixed :) |
π Description
Implementing Right to Left support and Arabic Language support
β Context
β Checklist
πΈ Demo
Screen_Recording_20220923-124816_LL.STAGING.mp4
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.