Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/LIVE-3665 - NFT gallery #1775

Merged
merged 54 commits into from
Nov 21, 2022
Merged

Conversation

nparigi-ledger
Copy link
Contributor

@nparigi-ledger nparigi-ledger commented Nov 9, 2022

📝 Description

NFT Gallery : Surfacing collected NFTs in a gallery, accessible from the LLM Wallet screen.

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Full state :

Screen_Recording_20221116-182453_LL.DEV.mp4

Reborn state :

Screen_Recording_20221116-184621_LL.DEV.mp4

Empty state :

Screen_Recording_20221116-184806_LL.DEV.mp4

NFT Gallery Feature flag disabled :

Screen_Recording_20221116-184920_LL.DEV.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

nparigi-ledger and others added 27 commits September 30, 2022 16:05
* ✨ feat(Add): Add new button

* 💄 Polishing
* Wip tab navigator

* Customize tab navigator style + new (empty) wallet nft gallery screen

* tab bavigator initial route

* fix padding

* fix padding
* ✨ FlatList with NFTs and Add new button

* 🐛(fix): Remove RectButton + add Select crypto flow

* ✨ Get NFTs and display in NFTs Tab
* Wip tab navigator

* Customize tab navigator style + new (empty) wallet nft gallery screen

* tab bavigator initial route

* fix padding

* fix padding

* tab navigator analytics
Handle nft gallery list empty state + bonus fix Link eslint for project
* ✨ Sorted List

* Fix typo
…ft viewer page (and back) (#1476)

Handle nft gallery list navigation too nft viewer page (and back)
… in store and use it (#1505)

Save wallet navigator last visited tab in store and use it + memoize wallet tab tab bar
* 🚧 Wip

* 🚧 WIP 2

* ♻️  Support ETH & Polygon + move logic in live-common

* 🔇 Remove console
* Static header in top of wallet tab navigator tabs
* ♻️  Skelleton as Styled

* 📝 Review
…s drawer (#1613)

LLM - Hide whole NFT collection from Individual NFT settings drawer (#1613)
…T Gallery (#1631)

* ✨  FEAT: LLM - NFT GAllery - ERC-1155 individual NFT display in the NFT Gallery

* 📝 Review
Feat/LIVE-3831 - NFT Gallery - Wallet navigator header animation (#1607)
* Change header layout - add scrolling animation to the header : new WalletTabNavigatorScrollManager.tsx
Feat/LIVE-4049 - NFT viewer page design fix (v3) (#1652)
* NFT Viewer page v3 redesign (properties list component etc)
* 💄 Polishing Millestone 2 - NFT gallery

* Remove ForceTheme
…lag + improv animations (#1707)

Feat/LIVE-4284 - Nft Gallery - Put the nft gallery behind a feature flag + improv animations (#1707)
- update @react-navigation/material-top-tabs react-native-pager-view react-native-tab-view because material top tabs was too old, and we need the latest update for animating the swipe. The other packages are dependencies of this one.
- Add feature flag walletNftGallery
- use feature flag nft gallery for wallet tab navigator
- use animation on scroll X and Y for gradient
* 💄 Polishing UI review

* 🔥 unused imports

* 💄 LIVE-4400: Remove token id in the NFT card

* 📝 Explicit name
* Update graph tabs to figma design system - update nft empty state copy - update navigator tab bar

* Remove fixed with from nft list item - add 16px margin between list items - PortfolioEmptyState.tsx pixel polish
…IVE-3665-nft-gallery-v0

# Conflicts:
#	apps/ledger-live-mobile/package.json
#	apps/ledger-live-mobile/src/actions/settings.ts
#	apps/ledger-live-mobile/src/components/Nft/NftLinksPanel.tsx
#	apps/ledger-live-mobile/src/components/Nft/NftViewer.tsx
#	apps/ledger-live-mobile/src/components/RootNavigator/PortfolioNavigator.tsx
#	apps/ledger-live-mobile/src/components/Skeleton.tsx
#	apps/ledger-live-mobile/src/const/navigation.ts
#	apps/ledger-live-mobile/src/reducers/settings.ts
#	apps/ledger-live-mobile/src/screens/Portfolio/Header.tsx
#	apps/ledger-live-mobile/src/screens/Portfolio/ReadOnly/index.tsx
#	apps/ledger-live-mobile/src/screens/Portfolio/index.tsx
#	libs/ledgerjs/packages/types-live/src/feature.ts
#	pnpm-lock.yaml
@vercel
Copy link

vercel bot commented Nov 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 5:15PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 21, 2022 at 5:15PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 5:15PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 5:15PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2022

🦋 Changeset detected

Latest commit: a3731a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@ledgerhq/live-common Minor
live-mobile Minor
@ledgerhq/types-live Minor
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

* 📈 Track analytics when user have NFTs

* 📈 Track analytics read-only
…fixes (#1890)

NFT List :
- Fix nft amount, wrong number was used
- fix placeholder for empty name
- now we use collectionMetadata for nft collection name, no more empty collection
…IVE-3665-nft-gallery-v0

# Conflicts:
#	pnpm-lock.yaml
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 42.51% // Head: 43.45% // Increases project coverage by +0.93% 🎉

Coverage data is based on head (a3731a3) compared to base (3871b77).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1775      +/-   ##
===========================================
+ Coverage    42.51%   43.45%   +0.93%     
===========================================
  Files          621      637      +16     
  Lines        25775    26382     +607     
  Branches      7140     7258     +118     
===========================================
+ Hits         10957    11463     +506     
- Misses       13661    13747      +86     
- Partials      1157     1172      +15     
Flag Coverage Δ
test 43.45% <96.29%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ledger-live-common/src/families/tezos/bridge/js.ts 17.70% <0.00%> (ø)
...er-live-common/src/featureFlags/defaultFeatures.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/mock/fixtures/nfts.ts 94.59% <94.59%> (ø)
libs/ledger-live-common/src/mock/account.ts 96.52% <100.00%> (+0.34%) ⬆️
libs/ledger-live-common/src/nft/helpers.ts 60.37% <100.00%> (+19.35%) ⬆️
libs/ledgerjs/packages/cryptoassets/data/erc20.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/trc10.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/tokens.ts 75.40% <0.00%> (ø)
...dgerjs/packages/cryptoassets/data/cardanoNative.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/fiats.ts 100.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…IVE-3665-nft-gallery-v0

# Conflicts:
#	libs/ledger-live-common/src/featureFlags/defaultFeatures.ts
#	libs/ledgerjs/packages/types-live/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants