Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Classification 3/n #1145

Merged
merged 40 commits into from
Jul 22, 2022
Merged

[Refactor] Classification 3/n #1145

merged 40 commits into from
Jul 22, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 15, 2022 •
edited
Loading

What does this PR do?

Continues work on classification refactor #1001
Prior work:

This PR takes care of precision, recall, fbeta and f1 metrics which all are subclasses from the stat scores metric. Smaller changes to other files as I found a couple of mistakes from the prior work.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added enhancement New feature or request Priority Critical task/issue refactoring refactoring and code health labels Jul 15, 2022
@SkafteNicki SkafteNicki added this to the v0.10 milestone Jul 15, 2022
SkafteNicki and others added 17 commits July 15, 2022 13:38
@SkafteNicki
working fbeta binary, multilabel
d57199f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f9541c1 
for more information, see https://pre-commit.ci
@SkafteNicki
precision and recall functional
503cb22
@SkafteNicki
Merge branch 'refactor/classification_3' of https://github.com/PyTorc…
a4cd83f 
…hLightning/metrics into refactor/classification_3
@SkafteNicki
Merge branch 'devel/classification' into refactor/classification_3
e3c014a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
00820c7 
for more information, see https://pre-commit.ci
@SkafteNicki
refactor testing
058278f
@SkafteNicki
working fbeta in all cases
e253fa2
@SkafteNicki
working precision recall with tests
f78045e
@SkafteNicki
formatting
c7a5c30
@SkafteNicki
Merge branch 'refactor/classification_3' of https://github.com/PyTorc…
329b728 
…hLightning/metrics into refactor/classification_3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ed58ce1 
for more information, see https://pre-commit.ci
@SkafteNicki
docs
6c2189f
@SkafteNicki
init files
7f77269
@SkafteNicki
fix stat score docstring
0e1f477
@SkafteNicki
docstrings
6a75270
@SkafteNicki
flake8
c9c350e
@SkafteNicki SkafteNicki marked this pull request as ready for review July 18, 2022 13:03
@mergify mergify bot removed the ready label Jul 19, 2022
@SkafteNicki SkafteNicki mentioned this pull request Jul 19, 2022
Merged
4 tasks
@mergify mergify bot added the ready label Jul 19, 2022
@mergify mergify bot removed the ready label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1145 (bb6425b) into devel/classification (087acad) will decrease coverage by 1%.
The diff coverage is 99%.

@@                  Coverage Diff                  @@
##           devel/classification   #1145    +/-   ##
=====================================================
- Coverage                    93%     92%    -1%     
=====================================================
  Files                       185     185            
  Lines                      9178    9398   +220     
=====================================================
+ Hits                       8530    8668   +138     
- Misses                      648     730    +82

@mergify mergify bot added the ready label Jul 19, 2022
@Borda
Copy link
Member

Borda commented Jul 20, 2022

@justusschock, mind having a look?

@SkafteNicki SkafteNicki merged commit acdad9d into devel/classification Jul 22, 2022
@SkafteNicki SkafteNicki deleted the refactor/classification_3 branch July 22, 2022 11:56
This was referenced Jul 22, 2022
Merged
Merged
This was referenced Aug 1, 2022
Merged
Merged
@SkafteNicki SkafteNicki mentioned this pull request Aug 20, 2022
Merged
4 tasks
Borda added a commit that referenced this pull request Aug 26, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 3/n (#1145)
5c669c7 
* fbeta init structure

* working fbeta binary, multilabel

* precision and recall functional

* refactor testing

* working fbeta in all cases

* working precision recall with tests

* formatting

* docs

* init files

* fix stat score docstring

* docstrings

* flake8

* add link

* fix integer division

* Apply suggestions from code review

* Apply suggestions from code review

* docs

* fix docs?

* naming mistake

* remove duplicate

* fix docs

* try fixing tests

* docs

* fix tests

* docs

* docs

* try again

* try again

* again

* again

* please fix

* please solve

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
@SkafteNicki SkafteNicki mentioned this pull request Aug 28, 2022
Merged
4 tasks
Borda added a commit that referenced this pull request Sep 12, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 3/n (#1145)
bae691c 
* fbeta init structure

* working fbeta binary, multilabel

* precision and recall functional

* refactor testing

* working fbeta in all cases

* working precision recall with tests

* formatting

* docs

* init files

* fix stat score docstring

* docstrings

* flake8

* add link

* fix integer division

* Apply suggestions from code review

* Apply suggestions from code review

* docs

* fix docs?

* naming mistake

* remove duplicate

* fix docs

* try fixing tests

* docs

* fix tests

* docs

* docs

* try again

* try again

* again

* again

* please fix

* please solve

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda added a commit that referenced this pull request Sep 12, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 3/n (#1145)
2179495 
* fbeta init structure

* working fbeta binary, multilabel

* precision and recall functional

* refactor testing

* working fbeta in all cases

* working precision recall with tests

* formatting

* docs

* init files

* fix stat score docstring

* docstrings

* flake8

* add link

* fix integer division

* Apply suggestions from code review

* Apply suggestions from code review

* docs

* fix docs?

* naming mistake

* remove duplicate

* fix docs

* try fixing tests

* docs

* fix tests

* docs

* docs

* try again

* try again

* again

* again

* please fix

* please solve

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda added a commit that referenced this pull request Sep 13, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 3/n (#1145)
0ce605d 
* fbeta init structure

* working fbeta binary, multilabel

* precision and recall functional

* refactor testing

* working fbeta in all cases

* working precision recall with tests

* formatting

* docs

* init files

* fix stat score docstring

* docstrings

* flake8

* add link

* fix integer division

* Apply suggestions from code review

* Apply suggestions from code review

* docs

* fix docs?

* naming mistake

* remove duplicate

* fix docs

* try fixing tests

* docs

* fix tests

* docs

* docs

* try again

* try again

* again

* again

* please fix

* please solve

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda added a commit that referenced this pull request Sep 13, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 3/n (#1145)
96a78a9 
* fbeta init structure

* working fbeta binary, multilabel

* precision and recall functional

* refactor testing

* working fbeta in all cases

* working precision recall with tests

* formatting

* docs

* init files

* fix stat score docstring

* docstrings

* flake8

* add link

* fix integer division

* Apply suggestions from code review

* Apply suggestions from code review

* docs

* fix docs?

* naming mistake

* remove duplicate

* fix docs

* try fixing tests

* docs

* fix tests

* docs

* docs

* try again

* try again

* again

* again

* please fix

* please solve

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
enhancement New feature or request Priority Critical task/issue ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@SkafteNicki @Borda @justusschock