[Refactor] Classification 7/n #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
enhancement
4 tasks
SkafteNicki
requested review from
edenlightning,
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
Codecov Report
@@ Coverage Diff @@
## devel/classification #1167 +/- ##
=====================================================
- Coverage 91% 90% -1%
=====================================================
Files 187 187
Lines 9642 9774 +132
=====================================================
+ Hits 8805 8843 +38
- Misses 837 931 +94 |
justusschock
approved these changes
Aug 16, 2022
4 tasks
Borda
pushed a commit
that referenced
this pull request
Aug 26, 2022
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
4 tasks
Borda
pushed a commit
that referenced
this pull request
Sep 12, 2022
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
Borda
pushed a commit
that referenced
this pull request
Sep 12, 2022
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
Borda
pushed a commit
that referenced
this pull request
Sep 13, 2022
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
Borda
pushed a commit
that referenced
this pull request
Sep 13, 2022
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues work on classification refactor #1001
Prior work:
This PR takes care of
coverage_error,label_ranking_average_precisionandlabel_ranking_loss. This PR is mostly a renaming since these metrics already only supports multilabel tasks, so no division into 3 seperate metrics nessesary. Addtionally, some standardization with the remaining of the codebase.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃