[Refactor] Classification 5/n #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
enhancement
SkafteNicki
requested review from
edenlightning,
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
Codecov Report
@@ Coverage Diff @@
## devel/classification #1159 +/- ##
=====================================================
- Coverage 92% 91% -0%
=====================================================
Files 185 187 +2
Lines 9513 9642 +129
=====================================================
+ Hits 8731 8805 +74
- Misses 782 837 +55 |
4 tasks
4 tasks
justusschock
approved these changes
Aug 1, 2022
Borda
approved these changes
Aug 2, 2022
| preds = preds.reshape(*preds.shape[:2], -1) | ||
| target = target.reshape(*target.shape[:2], -1) | ||
|
|
||
| if multidim_average == "global": |
There was a problem hiding this comment.
Can we split as two functions as they effectively are...
| assert torch.allclose(noneavg["res1"], result1, equal_nan=True) | ||
| result2 = acc(noneavg["pred2"], noneavg["target2"]) | ||
| assert torch.allclose(noneavg["res2"], result2, equal_nan=True) | ||
| # -------------------------- Old stuff -------------------------- |
There was a problem hiding this comment.
let's add todo for removal after merging back to master...
4 tasks
4 tasks
Borda
added a commit
that referenced
this pull request
Aug 26, 2022
* base structure * partly working accuracy * init files * working accuracy * exact match * mix mistake * exact matching * init files * fix doctest * mypy * fix docs * fix integer division * try fixing test dependency * fix f-string * fix integer division * fix integer division * fix? * try again * fix pep8 * docs * try something Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* base structure * partly working accuracy * init files * working accuracy * exact match * mix mistake * exact matching * init files * fix doctest * mypy * fix docs * fix integer division * try fixing test dependency * fix f-string * fix integer division * fix integer division * fix? * try again * fix pep8 * docs * try something Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* base structure * partly working accuracy * init files * working accuracy * exact match * mix mistake * exact matching * init files * fix doctest * mypy * fix docs * fix integer division * try fixing test dependency * fix f-string * fix integer division * fix integer division * fix? * try again * fix pep8 * docs * try something Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* base structure * partly working accuracy * init files * working accuracy * exact match * mix mistake * exact matching * init files * fix doctest * mypy * fix docs * fix integer division * try fixing test dependency * fix f-string * fix integer division * fix integer division * fix? * try again * fix pep8 * docs * try something Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* base structure * partly working accuracy * init files * working accuracy * exact match * mix mistake * exact matching * init files * fix doctest * mypy * fix docs * fix integer division * try fixing test dependency * fix f-string * fix integer division * fix integer division * fix? * try again * fix pep8 * docs * try something Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues work on classification refactor #1001
Prior work:
This PR takes care of
accuracymetric. Old implementation had an argumentsubset_accuracyto determine if subset accuracy (known as exact match also) should be calculated. To standardize with the rest of the metrics, this argument has been split into its own metricexact_match. This metric is then only implemented in the multilabel case, where this kind of evaluation is used.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃