[Refactor] Classification 8/n #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
enhancement
SkafteNicki
requested review from
edenlightning,
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
justusschock
approved these changes
Aug 16, 2022
Codecov Report
@@ Coverage Diff @@
## devel/classification #1175 +/- ##
======================================================
- Coverage 90% 52% -37%
======================================================
Files 189 189
Lines 10543 10767 +224
======================================================
- Hits 9469 5648 -3821
- Misses 1074 5119 +4045 |
4 tasks
Borda
added a commit
that referenced
this pull request
Aug 26, 2022
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <jirka.borovec@seznam.cz>
4 tasks
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues work on classification refactor #1001
Prior work:
This PR takes care of
calibration_errrorandhinge_losswhich are the final two metrics that need to be reformatted.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃