-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Classification 9/n #1189
[Refactor] Classification 9/n #1189
Conversation
Codecov Report
@@ Coverage Diff @@
## devel/classification #1189 +/- ##
====================================================
- Coverage 89% 89% -0%
====================================================
Files 189 191 +2
Lines 10767 10786 +19
====================================================
- Hits 9587 9577 -10
- Misses 1180 1209 +29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't strictly need to follow update-compute in our utils, especially if there is not modular interface so I propose a slightly more descriptive name :)
Other than that: LGTM as always :)
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * update doctests * doctests fix Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * update doctests * doctests fix Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * update doctests * doctests fix Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * update doctests * doctests fix Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> * update doctests * doctests fix Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
What does this PR do?
Continues work on classification refactor #1001
Prior work:
At this point the core implementations are in place and clean up is beginning. This PR takes care of 3 issues:
auc
is deprecated as an metric and moved to utilities as an compute tool instead. ModuleAUC
is completly deprecated and will be removed in future.kl_divergence
is deprecated from classification and moved to regression where it better fits (based on the fact thattarget
should be a float tensor for this metric)average
is changed frommicro
tomacro
. This is to prevent uses getting the same value fromprecision
,recall
andf1
in the multiclass/multilabel cases. Essentially the following holds:micro
in these cases, the underlying statistics just collapse into the same numbers in these cases. This change should hopefully prevent such confusion for users.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃