Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Classification 4/n #1151

Merged
merged 24 commits into from
Jul 23, 2022
Merged

[Refactor] Classification 4/n #1151

merged 24 commits into from
Jul 23, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 19, 2022 •
edited by Borda
Loading

What does this PR do?

Continues work on classification refactor #1001
Prior work:

This PR takes care of specificity and hamming_distance which are subclasses from the stat scores metric.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added enhancement New feature or request Priority Critical task/issue refactoring refactoring and code health labels Jul 19, 2022
@SkafteNicki SkafteNicki added this to the v0.10 milestone Jul 19, 2022
@SkafteNicki SkafteNicki changed the base branch from master to devel/classification July 19, 2022 09:45
pre-commit-ci bot and others added 11 commits July 19, 2022 09:45
@SkafteNicki SkafteNicki marked this pull request as ready for review July 21, 2022 14:40
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #1151 (130feb0) into devel/classification (acdad9d) will decrease coverage by 36%.
The diff coverage is 99%.

@@                  Coverage Diff                   @@
##           devel/classification   #1151     +/-   ##
======================================================
- Coverage                    88%     53%    -36%     
======================================================
  Files                       185     185             
  Lines                      9397    9513    +116     
======================================================
- Hits                       8301    5013   -3288     
- Misses                     1096    4500   +3404

@mergify mergify bot removed the has conflicts label Jul 22, 2022
@SkafteNicki SkafteNicki mentioned this pull request Jul 22, 2022
Merged
4 tasks
@mergify mergify bot added the ready label Jul 22, 2022
Borda
Borda approved these changes Jul 22, 2022
View reviewed changes
src/torchmetrics/classification/specificity.py Outdated Show resolved Hide resolved
src/torchmetrics/classification/specificity.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/classification/hamming.py Show resolved Hide resolved
src/torchmetrics/functional/classification/specificity.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/classification/specificity.py Outdated Show resolved Hide resolved
tests/unittests/classification/test_hamming_distance.py Outdated Show resolved Hide resolved
tests/unittests/classification/test_specificity.py Outdated Show resolved Hide resolved
@Borda Borda merged commit 0eadf8e into devel/classification Jul 23, 2022
@Borda Borda deleted the refactor/classification_4 branch July 23, 2022 21:49
This was referenced Jul 28, 2022
Merged
Merged
@SkafteNicki SkafteNicki mentioned this pull request Aug 5, 2022
Merged
4 tasks
@SkafteNicki SkafteNicki mentioned this pull request Aug 20, 2022
Merged
4 tasks
Borda added a commit that referenced this pull request Aug 26, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 4/n (#1151)
b147f30 
* docs

* update

* hamming

* working specificity

* hamming base structure

* init files for specificity

* done with specificity

* bit working hamming

* working hamming

* init files

* docstring

* specificity fix docs

* fix float division

* local/global

* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@SkafteNicki SkafteNicki mentioned this pull request Aug 28, 2022
Merged
4 tasks
Borda added a commit that referenced this pull request Sep 12, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 4/n (#1151)
29bae38 
* docs

* update

* hamming

* working specificity

* hamming base structure

* init files for specificity

* done with specificity

* bit working hamming

* working hamming

* init files

* docstring

* specificity fix docs

* fix float division

* local/global

* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda added a commit that referenced this pull request Sep 12, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 4/n (#1151)
520a8af 
* docs

* update

* hamming

* working specificity

* hamming base structure

* init files for specificity

* done with specificity

* bit working hamming

* working hamming

* init files

* docstring

* specificity fix docs

* fix float division

* local/global

* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda added a commit that referenced this pull request Sep 13, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 4/n (#1151)
a162464 
* docs

* update

* hamming

* working specificity

* hamming base structure

* init files for specificity

* done with specificity

* bit working hamming

* working hamming

* init files

* docstring

* specificity fix docs

* fix float division

* local/global

* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda added a commit that referenced this pull request Sep 13, 2022
@SkafteNicki @pre-commit-ci @Borda
[Refactor] Classification 4/n (#1151)
32e2190 
* docs

* update

* hamming

* working specificity

* hamming base structure

* init files for specificity

* done with specificity

* bit working hamming

* working hamming

* init files

* docstring

* specificity fix docs

* fix float division

* local/global

* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
enhancement New feature or request Priority Critical task/issue ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@SkafteNicki @Borda @justusschock