Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Extruder motor never turns off (SKR E3 DIP) #16753

Closed
opcow opened this issue Feb 1, 2020 · 10 comments
Closed

[BUG] Extruder motor never turns off (SKR E3 DIP) #16753

opcow opened this issue Feb 1, 2020 · 10 comments
Labels
A: STM32 Bug: Potential ? Needs: More Data We need more data in order to proceed

Comments

@opcow
Copy link

opcow commented Feb 1, 2020

Bug Description

The E stepper doesn't disable after it has been enabled.

I noticed a couple of hours after a print had finished that the extruder stepper was still on. Neither using the LCD's disable steppers command, Octoprint's motors off button, or sending the M18 command to the printer would turn off the stepper. Power cycling (or causing a reboot using M997) was the only way to get the E motor turned off.

My Configurations

configs.zip

Steps to Reproduce

  1. Issue command M17 E.
  2. Check that extruder stepper motor is energized.
  3. Issue command M18 E
  4. Check that extruder stepper motor is de-energized.

Expected behavior:
Stepper will turn off after the M18 E command.

Actual behavior:
Stepper remains energized after the M18 E command.

Additional Information

The board is an SKR E3 DIP (STM32F103RC). I'm using TMC2208 drivers on XYZ and a DRV8825 on E. If I build 2.0.2 using the same configuration the problem does not exist.

I tried using M18 E0 and M18 E1 commands as well. Same result.
@opcow opcow changed the title [BUG] SKR E3 DIP Extruder motor never turns off once energized [BUG] Extruder motor never turns off once energized (SKR E3 DIP / release 2.0.3) Feb 1, 2020
@thinkyhead thinkyhead changed the title [BUG] Extruder motor never turns off once energized (SKR E3 DIP / release 2.0.3) [BUG] Extruder motor never turns off (SKR E3 DIP) Feb 1, 2020
@thinkyhead
Copy link
Member

thinkyhead commented Feb 1, 2020 •
edited
Loading

  • Every time you print the stepper won't turn off?
  • Every time you turn the stepper on it won't turn off?

@opcow
Copy link
Author

opcow commented Feb 1, 2020

Correct. If the stepper motor ever turns on it will not turn off again until I power cycle the machine.

@opcow
Copy link
Author

opcow commented Feb 1, 2020

I switched out the DRV8825 for a TMC2208 and reconfigured for that. Same issue. The E stepper will never turn off once it has been turned on.

@thinkyhead
Copy link
Member

thinkyhead commented Feb 1, 2020 •
edited
Loading

Very interesting…. I did a diff and looked for relevant changes between 2.0.2 and 2.0.3 and nothing jumped out. I was thinking perhaps the disable for extruders was broken. But I see nothing unusual going on in the firmware.

Here is something you can try, but use caution! … Exchange the pin numbers of the E0_STEP, DIR, and ENA pins with those of X STEP,DIR,ENA pins in the E3 DIP pins file and re-build. Now, don't do anything except the M18 to turn the "E" stepper on and off. See if the X stepper now turns on and off when you tell the E stepper to turn on and off. As soon as you get the results, flash it back the old way.

Use the latest bugfix because it's had a few patches today and maybe one of them will have an effect.

I will continue to look at the code that disables E steppers and see if anything looks weird.

One other thing you can do is to enable PINS_DEBUGGING and use M43 and get a pins report. This will tell at least tell us if we have pins conflicting someplace.

I'll continue to keep my eyes open for some recent change that looks suspicious.

@thinkyhead thinkyhead added Bug: Potential ? Needs: More Data We need more data in order to proceed labels Feb 1, 2020
@opcow
Copy link
Author

opcow commented Feb 2, 2020

OK, did the pin swapping. The X stepper turns on with M17 E, but it won't turn off. So same behavior except on X instead of E.

@dongl1
Copy link

dongl1 commented Feb 2, 2020

I'm having the same issues with 2.0.3 on a ReArm with ramps 1.6 as well. When I switch back to 2.0.2 everything works as it should. I've attached my configuration files. I am running dual extruders and the issue is there for both steppers.
Configuration.zip

@boelle boelle added the A: STM32 label Feb 3, 2020
@thinkyhead
Copy link
Member

Thanks for the extra info. That implies it is not platform-specific but that something else is going on. I am checking through all the changes right now and hopefully it will be something obvious.

thinkyhead added a commit that referenced this issue Feb 4, 2020
@thinkyhead
Fix E stepper stays on bug
15b6ad4 
Fixes #16753
@thinkyhead
Copy link
Member

Problem solved. A rather foolish typo caused this, sorry!

@opcow
Copy link
Author

opcow commented Feb 4, 2020

Yup, that fixed it.

This was referenced Feb 9, 2020
Closed
Closed
@holgerpieta holgerpieta mentioned this issue Feb 21, 2020
Closed
StJa added a commit to StJa/Marlin that referenced this issue Mar 9, 2020
@StJa @thinkyhead
@Acenotass @rebel1 @sjasonsmith @InsanityAutomation @ellensp @felixstorm-c4a8 @Bob-the-Kuhn @thisiskeithb @tpruvot @robbycandra @StoneColdCrazy @Fabi0San @GMagician @DanielMazurkiewicz @tol2cj @proferabg @darksiah @Vertabreak @gdombiak @vivian-ng @GerogeFu @ktand @vector76 @zmiguel @marciot @josedpedroso @mak0t0san @rmoravcik
Sync Marlin Base (#2)
22bfe65 
* Add sanity-check for new Advanced Pause option

Followup to MarlinFirmware#16372

* Include macros for delta ABC

* Update Russian language (MarlinFirmware#16745)

* Fix BTT SKR 1.4 extra endstop pins (MarlinFirmware#16738)

* Option for Trigorilla 1.4 with add-on endstops board (MarlinFirmware#16737)

* Consistent M112 with Emergency Parser (MarlinFirmware#16747)

* Improve mfadd helper script

- Use the original branch name if none is supplied
- Set the remote tracking to the source
- Accept User/Branch or User:Branch syntax

* Clean up i2c encoder, sanitize serial

* Misc cleanup, whitespace

* Encapsulate probe as singleton class (MarlinFirmware#16751)

* G34 automatic point assignment (MarlinFirmware#16473)

* Fix Temperature::over_autostart_threshold (MarlinFirmware#16749)

* Update Russian language (MarlinFirmware#16750)

* Fix CURRENT_STEP_DOWN compile error

* Drop obsolete SD special char handling

See MarlinFirmware#14035

* Probe singleton patch

Followup to MarlinFirmware#16751

* Fix RGB / Neopixel white color bug

See MarlinFirmware#16752

* Suppress a compile warning

* More 8-extruder fixups

* Add EXP labels to SKR pins

* Fix LPC build with USE_WATCHDOG off

* Minor string storage optimization

* Apply REPEAT, RREPEAT, and loop macros (MarlinFirmware#16757)

* Revert breaking change to _FAN_PWM macro

* Add Z_AFTER_HOMING to raise Z more in G28 (MarlinFirmware#16755)

* Corner Leveling: Add inset for each side (MarlinFirmware#16759)

* (c) 2020

* Tweak mfqp script

* Use a different Configurations branch for CI

* Fix LCD Z Move character LCD display line (MarlinFirmware#16772)

* Fix warning for ESP32 (MarlinFirmware#16771)

* [cron] Bump distribution date

* Force T0 in UBL G29 on all multi-hotend setups (MarlinFirmware#16774)

* Keep secure credentials in a separate config file (MarlinFirmware#16773)

* STM32duino - Use SDIO for onboard SD (MarlinFirmware#16756)

* Fix E stepper stays on bug

Fixes MarlinFirmware#16753

* Fix Arduino IDE compile for DUE

Fixes MarlinFirmware#16767

* Fix CALIBRATION_GCODE pin handling

* Upgrade an ifdef

* More updates for 8 extruders, REPEAT

* [cron] Bump distribution date (2020-02-05)

* Add MKS Base 1.6 board (MarlinFirmware#16783)

* Direct download link for configs

* [cron] Bump distribution date (2020-02-06)

* Split up MKS_RUMBA32 into two variants (MarlinFirmware#16781)

* G26: Allow to set retraction for UBL mesh test (MarlinFirmware#16511)

* Remove extraneous Serial init (MarlinFirmware#16794)

* Fix probe with multi-endstops (MarlinFirmware#16793)

* [cron] Bump distribution date (2020-02-07)

* [cron] Bump distribution date (2020-02-08)

* Clean up Makefle indentation

* Add .editorconfig file

* Tweak ABL logging, document probing

* [cron] Bump distribution date (2020-02-09)

* Coolstep for TMC2130, 2209, 5130, 5160 (MarlinFirmware#16790)

* Better probe fail handling (MarlinFirmware#16811)

* Adafruit Grand Central M4 fixes (MarlinFirmware#16812)

* Minor HAL cleanup

* Move MSG_MARLIN

* Show print time with PRINTER_EVENT_LEDS

* Tweak parser warning

* Bump config version to 020004 (MarlinFirmware#16816)

* Add PID, probe offsets to ExtUI (MarlinFirmware#16792)

* [cron] Bump distribution date (2020-02-10)

* Tweak LPC1768 upload py script

* Add mftest -b (auto-build) and -u (upload)

- Implement the equivalent of auto-build for the shell environment by using the MOTHERBOARD setting to look up the env: entries.

* Revert change to AXIS_DRIVER_TYPE_X2

- Revisit this to figure out why it breaks

* Revert "Coolstep for TMC2130, 2209, 5130, 5160"

Reverting MarlinFirmware#16790 as not ready for primetime.

* Add a caution to drivers.h

* Update MKS BASE and v1.6 pins (MarlinFirmware#16806)

* Add g-code quoted strings, improve stream code (MarlinFirmware#16818)

* Fix out-of-order M0 after SD printing

Fixes MarlinFirmware#14774

Co-Authored-By: tol2cj <tol2cj@users.noreply.github.com>

* Fix out-of-order M0 after SD printing

Fixes MarlinFirmware#14774

Co-Authored-By: tol2cj <tol2cj@users.noreply.github.com>

* Enable hotend / bed PID separately in ExtUI (MarlinFirmware#16827)

* Fix MKS Robin Nano platformio.ini entry (MarlinFirmware#16826)

* Unify step pulse timing of ISR / babystep (MarlinFirmware#16813)

* [cron] Bump distribution date (2020-02-11)

* Update SAMD51 EEPROM repo link (MarlinFirmware#16832)

* Undo driver type auto-assignment for now

Good general concept but needs more time to develop and group with a stepper suite.

* No Z sensorless req'd if homing with probe

Fixes MarlinFirmware#16674

* Recommend Z Safe Homing

Co-Authored-By: Vertabreaker <opyrus@hotmail.com>

* Use prior babystep delay method (MarlinFirmware#16833)

* Function-style critical section macros

* Fix up tests

* Simplify old safe homing sanity check

* Prevent pin glitches on out commutation (MarlinFirmware#16835)

Better for switching from pulled input to output and also set real output (with no input enabled).

* [cron] Bump distribution date (2020-02-12)

* Define MarlinSerial instances for DGUS (MarlinFirmware#16841)

* No limit needed on this raise

Remove an extraneous limit from MarlinFirmware#16811.

* [cron] Bump distribution date (2020-02-13)

* [cron] Bump distribution date (2020-02-14)

* Fix G-code line parsing (MarlinFirmware#16840)

* Ping the job timer in M140 (MarlinFirmware#16849)

* Remove unused queue.stopped_N (MarlinFirmware#16850)

* Don't assert safe homing for delta/scara

* Fix ESP32 warning, specify supported version

* Add ESPAsyncTCP to lib_ignore (MarlinFirmware#16844)

* Add RAMPS 1.4.4 to AGCM4 (MarlinFirmware#16606)

* Clean up host actions code (MarlinFirmware#16856)

* Optimize "Dismiss" string

* Clean up stepper and babystep (MarlinFirmware#16857)

* Fysetc S6 pins / LCD updates (MarlinFirmware#16830)

* [cron] Bump distribution date (2020-02-15)

* Fix mftest -b and -u. Add --help.

* Fix a BORG compile warning

* Fix byte-to-percent display

Fixes MarlinFirmware#16866

* Conceal float rounding errors on display

Fix MarlinFirmware#16866

* [cron] Bump distribution date (2020-02-16)

* Double ADC read frequency (MarlinFirmware#16864)

* EXPERIMENTAL integrated BABYSTEPPING (MarlinFirmware#16829)

* Show '*' for zero 'stst' flag

* Require TMCStepper 0.6.2

* Defer updated ADC

* Move SAMD51 Temperature timer to RTC (MarlinFirmware#16868)

* Fix unknown command on empty lines (MarlinFirmware#16867)

* Fix mftest -b -u line match

* Update French language (MarlinFirmware#16877)

* Put ESP32 I2S stepper task and Marlin on the same core (MarlinFirmware#16874)

* Fix babystep include, typos in stepper.cpp

Fix MarlinFirmware#16881

* [cron] Bump distribution date (2020-02-17)

* [cron] Bump distribution date (2020-02-18)

* [cron] Bump distribution date (2020-02-19)

* [cron] Bump distribution date (2020-02-20)

* Serial redirect for Move Command when stopping (MarlinFirmware#16906)

* [cron] Bump distribution date (2020-02-21)

* Single envs for specific boards

* Inline manage_inactivity, tweak autoreport_paused

* Function for CONFIG_ECHO_HEADING

* Show end prompt with Print Event LEDs

* Add a note on EEPROM todo

* Tweak process_line_done for speed

* More EEPROM cleanup

* Followup to autoreport patch (MarlinFirmware#16914)

See a1f026f

* Disable spreadcycle in tmc_enable_stallguard<2209> (MarlinFirmware#16890)

* Fix EEPROM errors with EXTRUDERS == 0 (MarlinFirmware#16898)

* Add PICA shields support (MarlinFirmware#16891)

* Tweak pins spacing, comments

* Version 2.0.4 Release

* [cron] Bump distribution date (2020-02-22)

* Use moves_free in ok_to_send

* Hotfix for Babystepping

* CoreXY Babystepping hotfix

* Use moves_free in ok_to_send

* [cron] Bump distribution date (2020-02-22)

* Hotfix for Babystepping

* [ESP32] Allow user to define pins for hardware Serial1 and Serial2 (MarlinFirmware#16918)

* CoreXY Babystepping hotfix

* Version 2.0.4.1 Release

* [cron] Bump distribution date (2020-02-23)

* Finish Custom User Menu sanity-check (MarlinFirmware#16917)

* Followup to babystep hotfix

* Fix M0/M1 broken wait loop (MarlinFirmware#16921)

* Define ANET_FULL_GRAPHICS_LCD pins for SKR 1.4 (MarlinFirmware#16928)

* Version 2.0.4.2 Release

* Suppress "packed member" warning

* Suppress "packed member" warning

* Commit last SD line before fileHasFinished

* Allow LCD_PIXEL_WIDTH/HEIGHT override

* Allow USE_GCODE_SUBCODES for debugging

* Sync Italian language (MarlinFirmware#16935)

* Reduce default TMC baudrate to 57600 with Software Serial (MarlinFirmware#16930)

* [cron] Bump distribution date (2020-02-24)

* Fix AXIS_HAS_SW_SERIAL

* Simplified E_AXIS_HAS macro

* "Init. Media" => "Attach Media"

* Fix Babystepping loop (again)

* BS_TOTAL_AXIS => BS_TOTAL_IND

* Allow Z_SAFE_HOMING_POINT outside bed (MarlinFirmware#16945)

* Restore tabs in Makefile (MarlinFirmware#16944)

* Fix card_eof error

* Version 2.0.4.3 Release

* Allow Z_SAFE_HOMING_POINT outside bed (MarlinFirmware#16945)

* Restore tabs in Makefile (MarlinFirmware#16944)

* Fix card_eof error

* [cron] Bump distribution date (2020-02-25)

* Update POWER_LOSS_PIN comment (MarlinFirmware#16957)

* Update Italian language (MarlinFirmware#16947)

* Fix LCD cutter/bed icons overlapping (MarlinFirmware#16956)

* Fix SKR 1.4 Turbo SD_DETECT_PIN (MarlinFirmware#16955)

* Fix the wait loop in M0 / M1

* [cron] Bump distribution date (2020-02-26)

* Ensure proper SD print completion (MarlinFirmware#16967)

* HAS_SDCARD_CONNECTION is more obsolete

* Fix GTR10 overlapping defines (MarlinFirmware#16976)

* Toolchange improvements (MarlinFirmware#16979)

* Language: "failsafe" => "Defaults"

* Use a STR_ prefix for non-translated strings

* Set LCD status for EEPROM errors (MarlinFirmware#16977)

* More serial strings

* Add LPC1768 Serial ports for pinsDebug (MarlinFirmware#16980)

* Correct SKR expansion port pins (MarlinFirmware#16974)

* String optimize followup

* Fix Trinamic pulse rate auto-assignment (MarlinFirmware#16966)

* Allow weird probe values in G33

* Serial strings in macros

* Sanity check for LPC serial pin conflict (MarlinFirmware#16981)

* Allow servo features in combination (MarlinFirmware#16960)

* Add TRAVEL_EXTRA_XYJERK option

See MarlinFirmware#16949

Co-Authored-By: josedpedroso <josedpedroso@users.noreply.github.com>

* Quick-homing sensorless back-off (MarlinFirmware#16872)

* Prevent park_point compile error

* More extra travel jerk changes

Co-Authored-By: josedpedroso <josedpedroso@users.noreply.github.com>

* Fix unified status bed temp display

* Allow print recovery after parking

* Case-insensitive g-code option (MarlinFirmware#16932)

* Define DIAG pins for MKS SGen-L

* Handle print completed LED event in M0

* [cron] Bump distribution date (2020-02-27)

* Fix planner.cpp compile (MarlinFirmware#16996)

* Update Slovak language (MarlinFirmware#17002)

* Version 2.0.4.4 Release

Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Acenotass <44540957+Acenotass@users.noreply.github.com>
Co-authored-by: rebel1 <453277+rebel1@users.noreply.github.com>
Co-authored-by: Jason Smith <jason.inet@gmail.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com>
Co-authored-by: ellensp <ellensp@hotmail.com>
Co-authored-by: felixstorm <felix.storm@glueckkanja.com>
Co-authored-by: Bob Kuhn <bob.kuhn@att.net>
Co-authored-by: thisiskeithb <13375512+thisiskeithb@users.noreply.github.com>
Co-authored-by: Tanguy Pruvot <tpruvot@users.noreply.github.com>
Co-authored-by: Robby Candra <robbycandra.mail@gmail.com>
Co-authored-by: Robert Stein <robert.stein@requisis.com>
Co-authored-by: Fabio Santos <fabiosan@live.com>
Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com>
Co-authored-by: Daniel Mazurkiewicz <daniel@latanie.info>
Co-authored-by: tol2cj <tol2cj@users.noreply.github.com>
Co-authored-by: proferabg <proferabg@users.noreply.github.com>
Co-authored-by: darksiah <siatam@gmail.com>
Co-authored-by: Vertabreaker <opyrus@hotmail.com>
Co-authored-by: Gaston Dombiak <gdombiak@gmail.com>
Co-authored-by: vivian-ng <vivian@maplerain.com>
Co-authored-by: George Fu <nailao_5918@163.com>
Co-authored-by: Karl Andersson <karl@iaccess.se>
Co-authored-by: Jamie <vector76@users.noreply.github.com>
Co-authored-by: ZMiguel Alves <zmiguel@users.noreply.github.com>
Co-authored-by: Marcio T <mlt4356-github@yahoo.com>
Co-authored-by: josedpedroso <josedpedroso@users.noreply.github.com>
Co-authored-by: Makoto Schoppert <makotosan@gmail.com>
Co-authored-by: Roman Moravčík <roman.moravcik@gmail.com>
@StJa StJa mentioned this issue Mar 9, 2020
Closed
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A: STM32 Bug: Potential ? Needs: More Data We need more data in order to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync Marlin Base (#2) StJa/Marlin
4 participants
@opcow @thinkyhead @boelle @dongl1