[FR] (M117 command)

[sandroxGH]

Is possible only for the M117 command have the possibility to print the ":" character on screen,
I wold like to display the estimate printi time for example M117 Time 1:01:00

[Ludy87]

try & Error 😉

[ghost]

Works for me ..

M117 Hi :Gorgous:

[PC-maniak]

Hello i try and ":" not working .. i send M117 Layer : 1/69

and i get "Layer " only.. hmmm

tested on latest /// 1.1.x "bugfix" snapshot Patches after 1.1.9 ///

[igorepi]

M177 with ":" does work when this command is received from UART. Same command doesn't work when printing from SD card, at least in Marlin 1.1.9.

[PC-maniak]

Aa yes i tested from SD card

[InsanityAutomation]

Can you check with bugfix-2.0.x? 1.1.x is EOL and wont be getting more updates. The SD parser may be stripping them out as comments, but 2.0 has had about a year of development on top of 1.1.9....

[PC-maniak]

yes i will try it on weekend on re-arm board
and write the result

[igorepi]

Just checked with latest bugfix-2.0.x - same behavior as in 1.1.9. Everything after ":" is stripping out by SD parser.

[PC-maniak]

Yes same here ->blah:bluh i get only "blah"

[AnHardt]

There is a half a special handling of ':' in https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/gcode/queue.cpp#L741 when read from SD.
The line is ended, but I can't see special function of ':'.
Try to remove and see what happens.

[sandroxGH]

Can be possible remove from
https://github.com/MarlinFirmware/Marlin/blob/1.1.x/Marlin/Marlin_main.cpp#L1189
the "sd_char == ':' " to print correctly on the screen

[AnHardt]

The line seems to belong to a lost/vergotten feature. At least i can neither find documentation nor handling '#' and ':' anywhere else in the code.
Try to comment out the complete line

//          || ((sd_char == '#' || sd_char == ':') && !sd_comment_mode)

Test that and come back with the results. Do you see any regressions or improvements?

[boelle]

so is this a bug or feature request?

[sandroxGH]

Hello I've try to comment the line suggest on Marlin_main.ccp line 1189 "|| ((sd_char == '#' || sd_char == ':') && !sd_comment_mode)" it working fine from two weeks printing from SD with out any side effect. Thanks Il giorno dom 21 lug 2019 alle ore 14:58 Bo Herrmannsen < notifications@github.com> ha scritto:

…

so is this a bug or feature request? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14035?email_source=notifications&email_token=AB3P44QDVRA7AOFL4VQE3QLQARMP3A5CNFSM4HNM3FQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2OC6ZQ#issuecomment-513552230>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3P44QPD7NSKQCDWFPV2KTQARMP3ANCNFSM4HNM3FQQ> .

[jimb15122]

Hi. This issue should be reclassified as a bug.
The M117 command cannot display the : and # characters when the command is read from SD card. This bug also causes the text that appears after the symbol to be truncated, and be processed as a subsequent command. (Can you spell attack surface?) The : and # characters are being interpreted as end of line characters.

I remember seeing a mention somewhere on the web that the : character was used in some gcode generators as a way to pack multiple commands on a single line. But for the life of me I could not anything on the net mentioning this practice. Since this "support" is not mentioned on the official reprap gcode, the special checks for these characters should be removed from queue.cpp. I do not think these were typos. They are either intentional (but undocumented) support for multi command packing, or a left over developer debug hack. This problem exists in both the 1.x and 2.x versions.

[thinkyhead]

I believe this must be left over from early attempts to do sub-calls. They aren't needed any more, so have been removed.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.