Code cleanup for #4000 #4054
Merged
Code cleanup for #4000 #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… casts, and instanceof checks in favor of single if block
Codecov ReportBase: 23.03% // Head: 23.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4054 +/- ##
============================================
- Coverage 23.03% 23.00% -0.03%
Complexity 4813 4813
============================================
Files 2263 2264 +1
Lines 248731 249501 +770
Branches 46244 46321 +77
============================================
+ Hits 57283 57398 +115
- Misses 189989 190644 +655
Partials 1459 1459
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Windchild292
suggested changes
Dec 17, 2022
| @@ -404,36 +404,31 @@ else if ((entity.heat >= 14) && !entity.isShutDown()) { | |||
|
|
|||
| public static void adjustHeatExtremeTemp(Game game, Entity entity, Vector<Report> vPhaseReport) { | |||
| Report r; | |||
| int tempDiff = game.getPlanetaryConditions().getTemperatureDifference(50, -30); | |||
| int tempDiff = game.getPlanetaryConditions().getTemperatureDifference(50, -30); | |||
| boolean heatArmor =false; | |||
There was a problem hiding this comment.
Suggested change
| boolean heatArmor =false; | |
| boolean heatArmor = false; |
Windchild292
added
Refactoring
For New Dev Cycle
Windchild292
approved these changes
Dec 17, 2022
HammerGS
added a commit
to SJuliez/megamek
that referenced
this pull request
May 25, 2024
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix #MegaMek#1514: Fix Atrocious table shading render speed MekHQ + PR MegaMek#4106: Use tabs in customize scenario dialog + PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners + PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change for PR #4000 Consolidated some code removing several if blocks moving them into a single if statement at the beginning of the function which relocated two class casts and removed multiple if statements for boolean variables. Not sure if it will have a positive impact on performance but it does clean up the code some.