Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPA: Terrain Master [Nightwalker] #4102

Merged
merged 7 commits into from
Jan 29, 2023

Conversation

pheonixstorm
Copy link
Collaborator

I have been sitting on this for several years in a vain attempt to find a way to allow for the full rules used for Nightwalker. I never could find a solution, and it seems I wasn't the only one as Nick tried as well and gave up on it.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 22.97% // Head: 22.95% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (587bd68) compared to base (492a8d6).
Patch coverage: 4.76% of modified lines in pull request are covered.

❗ Current head 587bd68 differs from pull request most recent head fb92f06. Consider uploading reports for the commit fb92f06 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4102      +/-   ##
============================================
- Coverage     22.97%   22.95%   -0.02%     
+ Complexity     4824     4819       -5     
============================================
  Files          2282     2282              
  Lines        250115   250321     +206     
  Branches      46366    46373       +7     
============================================
+ Hits          57459    57461       +2     
- Misses       191204   191408     +204     
  Partials       1452     1452              
Impacted Files Coverage Δ
megamek/src/megamek/common/Aero.java 8.33% <0.00%> (-0.01%) ⬇️
megamek/src/megamek/common/Entity.java 12.87% <0.00%> (ø)
megamek/src/megamek/common/LandAirMech.java 0.00% <0.00%> (ø)
megamek/src/megamek/common/MoveStep.java 2.31% <0.00%> (-0.01%) ⬇️
megamek/src/megamek/common/VTOL.java 0.69% <0.00%> (-0.01%) ⬇️
...k/src/megamek/common/options/OptionsConstants.java 0.00% <ø> (ø)
...gamek/src/megamek/common/options/PilotOptions.java 100.00% <100.00%> (ø)
megamek/src/megamek/common/Team.java 18.89% <0.00%> (-18.99%) ⬇️
.../megamek/client/generator/RandomUnitGenerator.java 13.06% <0.00%> (-0.40%) ⬇️
megamek/src/megamek/common/Player.java 13.25% <0.00%> (-0.21%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things and a major question

megamek/i18n/megamek/common/options/messages.properties Outdated Show resolved Hide resolved
megamek/src/megamek/common/Entity.java Outdated Show resolved Hide resolved
megamek/src/megamek/common/options/OptionsConstants.java Outdated Show resolved Hide resolved
megamek/src/megamek/common/MoveStep.java Outdated Show resolved Hide resolved
pheonixstorm and others added 4 commits January 14, 2023 21:21
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
pheonixstorm and others added 2 commits January 29, 2023 14:48
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@pheonixstorm
Copy link
Collaborator Author

Made the other suggested change and fixed conflict status.

@Windchild292 Windchild292 merged commit 375e39b into MegaMek:master Jan 29, 2023
@pheonixstorm pheonixstorm deleted the SPA-TM-Nightwalker branch January 29, 2023 23:10
HammerGS added a commit to SJuliez/megamek that referenced this pull request May 25, 2024
MegaMek
+ Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively

MegaMekLab
+ Fix #MegaMek#1514: Fix Atrocious table shading render speed

MekHQ
+ PR MegaMek#4106: Use tabs in customize scenario dialog
+ PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners
+ PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards
+ PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel
+ PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel
+ PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module
            Very Important to read the documentation on this feature (See Docs folder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants