test: add accounts sync test with balance detection #28715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mathieuartu
reviewed
Nov 26, 2024
| await withFixtures( | ||
| { | ||
| fixtures: new FixtureBuilder({ onboarding: true }) | ||
| .withNetworkControllerOnMainnet() |
cmd-ob
changed the title
cmd-ob
changed the title
cmd-ob
added
accessibility
… e2e/syncing_with_balance_detection
## **Description** PR adds an e2e test to check polling activity [](https://codespaces.new/MetaMask/metamask-extension/pull/28682?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Change title and description for permit pages. ## **Related issues** Fixes: MetaMask/MetaMask-planning#3633 ## **Manual testing steps** 1. Enable permit signature decoding locally 2. Go to test dapp 3. Check title and description of permit pages ## **Screenshots/Recordings** <img width="356" alt="Screenshot 2024-11-19 at 3 46 02 PM" src="https://github.com/user-attachments/assets/41ca3226-4bc5-4022-9e71-8ba2200ae06b"> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
#28720) ## **Description** fix: transaction flow section layout on re-designed confirmation pages ## **Related issues** Ref: #28015 ## **Manual testing steps** 1. Open test dapp 2. Submit token transfer confirmation 3. Check layout of the page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="253" alt="Screenshot 2024-11-26 at 4 06 28 PM" src="https://github.com/user-attachments/assets/4680e7d7-2a2b-41cd-8df7-be10fe1442e8"> <!-- [screenshots/recordings] --> ### **After** <img width="357" alt="Screenshot 2024-11-26 at 4 06 15 PM" src="https://github.com/user-attachments/assets/66328717-0027-4a43-bc5b-4958d6e8a007"> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Bump Snaps packages and handle any required changes. Summary of Snaps changes: - Add `snap_getInterfaceContext` JSON-RPC method - Emit `snapInstalled` and `snapUpdated` events for preinstalled Snaps - This indirectly makes preinstalled Snaps trigger cronjobs and lifecycle hooks more reliably. Closes MetaMask/snaps#2899 Closes MetaMask/snaps#2901 [](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1)
…ask/metamask-extension into e2e/syncing_with_balance_detection
Builds ready [a7fb6c7]
Page Load Metrics (1719 ± 111 ms)
Bundle size diffs
|
mathieuartu
reviewed
Nov 26, 2024
| @@ -105,3 +106,63 @@ function mockAPICall(server: Mockttp, response: MockResponse) { | |||
| json: response.response, | |||
| })); | |||
| } | |||
|
|
|||
| type MockInfuraAndAccountSyncOptions = { | |||
Prithpal-Sooriya
approved these changes
Nov 26, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/28682?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E Test for Accounts Syncing when a user has more accounts with balances.
eth_getBalancein testunlockWalletto be used with custom passwordRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist