7.15.0 #8256

github-actions · 2024-01-11T22:13:54Z

This is the release candidate for version 7.15.0.

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net>

codecov-commenter · 2024-01-11T22:58:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3928f9e) 40.42% compared to head (c76eab6) 40.42%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8256   +/-   ##
=======================================
  Coverage   40.42%   40.42%           
=======================================
  Files        1239     1239           
  Lines       29975    29975           
  Branches     2869     2869           
=======================================
  Hits        12117    12117           
  Misses      17167    17167           
  Partials      691      691

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

## **Description** Merge 7.14.0 into working branch to prep for merge main  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net> Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> Co-authored-by: seaona <54408225+seaona@users.noreply.github.com> Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com> Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Xiaoming Wang <dawnseeker8@gmail.com> Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com> Co-authored-by: yande <110056475+Andepande@users.noreply.github.com> Co-authored-by: Yande <andepandy@outlook.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com> Co-authored-by: Curtis David <Curtis.David7@gmail.com> Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com> Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: hesterbruikman <hester.bruikman@consensys.net>

github-actions · 2024-01-11T23:16:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

chrisleewilcox · 2024-01-12T20:26:36Z

RC1 Smoke tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9ff3209-a8c1-4ee2-9cfb-211e404bafe3
RC1 Regression tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04770f56-b908-4cd7-97c0-93b7ad661680

## **Description** Cherry pick hotfixes from main & bump build number  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: Omri Dan <61094771+omridan159@users.noreply.github.com>

## **Description** Bump build to 1243  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Cherry-pick fix for PPOMController state initialisation is broken. This is resulting in blockaid files being downloaded each time app is re-opened. ## **Related issues** Fixes: #8280 ## **Manual testing steps** The issue is hard to test manually ## **Screenshots/Recordings** NA ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [X] I’ve properly set the pull request status: - [X] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

katkopel · 2024-01-19T05:34:56Z

Onboarding Custom Mainnet for v7.15.0 (1236) - RC 2 build on Xs Max, iOS 17.2.1 iOS
✅Verifying Custom Mainnet Screen Appears
✅Entering an Invalid Mainnet RPC URL
✅Entering a valid Mainnet RPC URL
✅Editing a custom mainnet URL on the settings and privacy view:
✅Deleting a custom mainnet URL on the settings and privacy view:
https://recordit.co/hegtr4r795

QR Scanner feature scenarios v7.15.0 (1236) - RC 2 build on Xs Max, iOS 17.2.1 iOS
✅ From the in-app camera I should be able to scan a valid QR code containing an address: 
https://recordit.co/wwMy8Xbgd1

✅ I should be able to use the QR scanner on the send flow to scan an address: 
https://recordit.co/EsUxRd0U9o

✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message:
https://recordit.co/XfE9s1lnY7

✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message:
https://recordit.co/RK8rAsIYOL

❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message:
FAILED: warning message not displayed
https://recordit.co/AqQuL5FCkI

✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message: 
https://recordit.co/ViizXBcUCD

✅ A user can scan a private key QR code using the in-app camera to import an account: 
https://recordit.co/jtUDOWM1V0

✅ User scans MMM Receive QR code on different networks, also tested with other account receiving account QR codes:
https://recordit.co/csZ1fdTlsm

Language testing for v7.15.0 (1236) - RC 2 build on Xs Max, iOS 17.2.1 iOS
✅ Changing the device language from English to Russian: 
https://recordit.co/JenShJKCqG

✅ Changing the app language from English to Filipino: 
https://recordit.co/g7SkcwG2FG

katkopel · 2024-01-19T19:50:05Z

Network Regression:
✅ I can remove a custom network (Palm) that was added via the popular network flow:
https://recordit.co/n39Vd53XtP

✅ I can remove a custom network that was added via the custom network flow:
https://recordit.co/oAFPtWPUI8

✅ Adding a network via a Dapp
https://recordit.co/SAFdHoyIpO

✅ Add a new popular network flow via the network page
https://recordit.co/XpkH5g1yNF

✅ Add a new custom network flow via the network flow
https://recordit.co/CMbP9QV4MA

Browser Regression:
✅ From the browser I can successfully upload a picture
https://recordit.co/aNHPmBG3cI

✅ Favorites: https://recordit.co/2pPFVqGNGH
❌ Homepage search - Fails to suggest Sushiswap URL link and suggests Uniswap instead when searching for Sushiswap: https://recordit.co/KX73KZnQAu
✅ Address bar: https://recordit.co/NseNA3akRz
✅ Navigation with browser controls: https://recordit.co/CScUzZrMxO
❗ Browser options - Share works. Account stays connected after switching from Ethereum > BNB: https://recordit.co/LloRcr35uh
✅ Switch account: https://recordit.co/0ZEqrMbMsa
✅ A user can test an ENS website: https://recordit.co/fBY76OwjLY
✅ A user enters a malicilous website and is greeted with the phishing detection warning: https://recordit.co/6hOIdM6mrj
✅ A user enters an invalid url: https://recordit.co/cSy3HE9ApS

❗Connect Wallet to Dapp or Marketplace - Failed to locate popular Rarible.com URL: https://recordit.co/d9KoBaAeAn

anaamolnar · 2024-01-19T21:18:05Z

Onboarding Custom Mainnet for v7.15.0 - RC1 build on Samsung A53, Android
✅Verifying Custom Mainnet Screen Appears
✅Entering an Invalid Mainnet RPC URL
✅Entering a valid Mainnet RPC URL
✅Editing a custom mainnet URL on the settings and privacy view:
✅Deleting a custom mainnet URL on the settings and privacy view:
https://recordit.co/tzwTmOUCjZ

ChangeLanguage.feature
✅ Changing the device language from English to Russian: 
https://recordit.co/cPLAslTarX
❌Changing the app language from English to Filipino: - No Filipino subtitle
https://recordit.co/ZocnkQv4lW

Browser.feature
https://recordit.co/ELffiNOdFv
https://recordit.co/HB5m6lJt5R - Does not suggest sushi.com, it is also not part of the explore sites section
https://recordit.co/GjVSfaFMu8
https://recordit.co/uYIpgxmQxH
https://recordit.co/7PsWjcrY91 - Uniswap does not allow normal connection because of the old bug; through wallet connect, I cannot switch to a different account
❌A user can test an ENS website
https://recordit.co/9h6vEVXHD7
https://recordit.co/bi9CcALvY4

❌UploadPicInBrowser.feature - Uploading a picture does not work
https://recordit.co/GL6sgmsC3V

✅ DappsMarketplace.feature - Nice Function Here Plz Click method shows
https://recordit.co/dcXVFkerwu

✅RemoveNetwork.feature
✅ AddCustomNetwork.feature
https://recordit.co/8iNjccxah4
"Do you want to remove this network" is not showing when deleting the network from the network details view

✅AddPopularNetwork.feature
https://recordit.co/6uMR4hXM5C

✅AddNetworkViaDapp.feature
https://recordit.co/Lxs9cwxoIT

anaamolnar · 2024-01-19T22:01:25Z

QR Scanner feature, v7.15.0 - RC1 build on Samsung A53, Android
✅ From the in-app camera I should be able to scan a valid QR code containing an address: 
✅ I should be able to use the QR scanner on the send flow to scan an address: 
https://recordit.co/ymsLjujeWM
❌ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message - Does not redirect me to the dapp
https://recordit.co/MsTRyNlkHm
✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message: 
https://recordit.co/bRsyjYFsHL
✅ A user can scan a private key QR code using the in-app camera to import an account: 
https://recordit.co/xomweFLhd5
✅ User scans MM Receive QR code on different networks:
https://recordit.co/JGT1jZYZDi

sleepytanya · 2024-01-22T23:08:24Z

Confirmations System team QA sign-off for the PRs included in current release candidate.

✅ Approve custom erc20 v2 #7736(no QA needed)
✅ Separate Detox build from test execution #7897
✅ Implement CCache to e2e builds #7975
✅ Handle Optional 'getCurrentAccount' in incoming transaction #8203

seaona · 2024-01-24T11:07:07Z

Confirmations UX team QA sign-off:
✅ https://github.com/MetaMask/metamask-mobile/pulls?q=is%3Apr+label%3Ateam-confirmations-secure-ux+label%3Arelease-7.15.0+
✅ https://github.com/MetaMask/metamask-mobile/pulls?q=is%3Apr+label%3Ateam-confirmations-secure-ux-PR+label%3Arelease-7.15.0+

SamuelSalas · 2024-01-25T16:34:59Z

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c6b30a1-4867-42cd-be6e-2c86cece3d26
Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d?branch=release%2F7.15.0

Swap tests failed on the smoke test run. We have already tested the release swap regression task and everything is working as expected.

SamuelSalas · 2024-01-26T01:11:21Z

Team Mobile Client QA sign-off for the PRs included in current release candidate.

✅ fix: refresh ownership status for nfts
✅ fix: update to unable to find conversion rate when failing to get conversion rate
✅ fix: fix padding tab, should be 16px
✅ fix: fix bug first NFT in collection gets always displayed

No QA needed, just regression
✅ ci: Remove using PACKAGE_READ_TOKEN for core preview builds
✅ refactor: E2e Smoke Tests to Execute Across Multiple Virtual Machines on Bitrise
✅ New Crowdin translations by Github Action
✅ feat: #870 - Slice Storage Engine
✅ feat: swaps on send flow when amount is insufficient
✅ feat: migrate to latest Token rates controller
✅ chore: cherry pick QR & migrations hotfixes into 7.15.0
✅ chore: fix ruby version and improve CI build time
✅ chore: upgrade to rn 0.71.15
✅ fix: dedupe deps
✅ fix: fix padding tab, should be 16px
✅ fix: Show deprecated exports on enzyme
✅ fix: Remove duplicate declarations and library
✅ fix: added resolution for follow-redirects
✅ fix: add RN patch for boost
✅ fix: ignore ppom when using yarn format
✅ fix(action): be more restrictive on the release branch format
✅ test: 1328 refactor modals page batch 1
✅ test: onboarding folder refactor page objects
✅ test: 8187 remove drawer folder e2e folder
✅ test: refactor Assertions class and update specs expect assertion
✅ test: Refactor Settings Contacts Folder page objects
✅ test: Batch 4 Remove all instances of strings in TestID property in the app code
✅ test: fix failing smoke test
✅ test: create additional e2e subfolders
✅ test: bump detox + implement dynamic scroll in e2e tests

SamuelSalas · 2024-01-26T19:11:14Z

Testing completed to the release task.

## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Build version bump to 1244. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

chrisleewilcox · 2024-01-28T04:31:37Z

RC3

Testruns were with a cherry-pick fix for swaps tests.
Smoke: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/98cf914e-c909-4511-9f10-c0168c6da8c3
Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc381daa-cc78-4a3d-99c8-4ac9d0ddc640

## **Description** Tests fix for #8342 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Davide Brocchetto <davide.brocchetto@consensys.net>

## **Description** cherry pick #8421 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Build version bump to 1245 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

SamuelSalas · 2024-01-29T22:26:44Z

v7.15.0 build 1245 has QA Sign-off

github-actions · 2024-01-29T23:04:14Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33c5da2d-c411-429e-80ae-46a514925c2f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

sonarqubecloud · 2024-01-29T23:13:07Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

chrisleewilcox

LGTM

SamuelSalas

LGTM

metamaskbot and others added 2 commits January 11, 2024 22:13

7.15.0

bd44203

New Crowdin translations by Github Action (#8030)

8b1ce0e

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com> Co-authored-by: sethkfman <seth.kaufman@consensys.net>

sethkfman added 2 commits January 11, 2024 16:16

updated changelog

cf42d9f

changelog conflicts

dada3fd

chrisleewilcox added team-mobile-client QA in Progress QA has started on the feature. labels Jan 11, 2024

metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 12, 2024

frankvonhoven and others added 3 commits January 16, 2024 17:13

frankvonhoven and others added 2 commits January 26, 2024 17:17

metamaskbot mentioned this pull request Jan 29, 2024

test: fix Swap test flakiness on Bitrise #8342

Merged

13 tasks

sethkfman and others added 2 commits January 29, 2024 13:55

sync with main

c76eab6

sethkfman marked this pull request as ready for review January 29, 2024 23:02

sethkfman requested a review from a team as a code owner January 29, 2024 23:02

github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 29, 2024

chrisleewilcox approved these changes Jan 29, 2024

View reviewed changes

SamuelSalas approved these changes Jan 29, 2024

View reviewed changes

sethkfman added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jan 30, 2024

sethkfman merged commit 0efe1c6 into main Jan 30, 2024
32 checks passed

github-actions bot locked and limited conversation to collaborators Jan 30, 2024

metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 30, 2024

gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.15.0 #8256

7.15.0 #8256

github-actions bot commented Jan 11, 2024

codecov-commenter commented Jan 11, 2024 •

edited

Loading

github-actions bot commented Jan 11, 2024

chrisleewilcox commented Jan 12, 2024 •

edited

Loading

katkopel commented Jan 19, 2024 •

edited

Loading

katkopel commented Jan 19, 2024 •

edited

Loading

anaamolnar commented Jan 19, 2024

anaamolnar commented Jan 19, 2024

sleepytanya commented Jan 22, 2024 •

edited

Loading

seaona commented Jan 24, 2024 •

edited

Loading

SamuelSalas commented Jan 25, 2024

SamuelSalas commented Jan 26, 2024

SamuelSalas commented Jan 26, 2024

chrisleewilcox commented Jan 28, 2024

SamuelSalas commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

sonarqubecloud bot commented Jan 29, 2024

chrisleewilcox left a comment

SamuelSalas left a comment

7.15.0 #8256

7.15.0 #8256

Conversation

github-actions bot commented Jan 11, 2024

codecov-commenter commented Jan 11, 2024 • edited Loading

Codecov Report

github-actions bot commented Jan 11, 2024

chrisleewilcox commented Jan 12, 2024 • edited Loading

katkopel commented Jan 19, 2024 • edited Loading

katkopel commented Jan 19, 2024 • edited Loading

anaamolnar commented Jan 19, 2024

anaamolnar commented Jan 19, 2024

sleepytanya commented Jan 22, 2024 • edited Loading

seaona commented Jan 24, 2024 • edited Loading

SamuelSalas commented Jan 25, 2024

SamuelSalas commented Jan 26, 2024

SamuelSalas commented Jan 26, 2024

chrisleewilcox commented Jan 28, 2024

SamuelSalas commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

sonarqubecloud bot commented Jan 29, 2024

Quality Gate passed

chrisleewilcox left a comment

Choose a reason for hiding this comment

SamuelSalas left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 11, 2024 •

edited

Loading

chrisleewilcox commented Jan 12, 2024 •

edited

Loading

katkopel commented Jan 19, 2024 •

edited

Loading

katkopel commented Jan 19, 2024 •

edited

Loading

sleepytanya commented Jan 22, 2024 •

edited

Loading

seaona commented Jan 24, 2024 •

edited

Loading