Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New event "adminhtml_sales_order_create_save_before" when editing an order. #1168

Merged
merged 2 commits into from
Jan 15, 2021
Merged

New event "adminhtml_sales_order_create_save_before" when editing an order. #1168

merged 2 commits into from
Jan 15, 2021

Conversation

woutersamaey
Copy link
Contributor

New event for when you're editing an order in Magento Admin and need to make changes to the old and/or new order before save.

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Aug 26, 2020
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Q: short array syntax y/n?

@colinmollenhour
Copy link
Member

lgtm

Q: short array syntax y/n?

Short array syntax is fine since PHP 5.4 and we list PHP 7.0 as a requirement (although I think 5.6 is still working).

@woutersamaey woutersamaey changed the title New event "order_edited_save_before" when editing an order. New event "adminhtml_sales_order_create_save_before" when editing an order. Aug 28, 2020
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 15, 2021
@sreichel sreichel merged commit 2a3918c into OpenMage:1.9.4.x Jan 15, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 2a3918c.

Flyingmana pushed a commit that referenced this pull request Feb 13, 2021
* Updated README.md, closes #992

- add branch alias to composer.json (see #992#issuecomment-638974892)
- add AFL 3.0 license
- removed duplicate LICENSE.html
- ...

* Renamed dev-master to dev-main

* Renamed dev-master to dev-main - missed one

* Added event #1168

Co-authored-by: Sven Reichel <sven.reichel@sandstein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants