Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enable_app_replacement param in app_manager #26

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Oct 13, 2020

I add enable_app_replacement parameter in app_manager.
This parameter enable us to control whether app_manager denies overwriting app or not.
In the following example, I set enable_app_replacement false, and app_manager denied go_to_kitchen app because time_signal app is still running.

fetch@fetch15:~/ros/indigo/src/jsk-ros-pkg/jsk_robot$ rosservice call /fetch15/start_app "name: 'jsk_fetch_startup/time_signal'" 
started: True
error_code: 0
message: app [jsk_fetch_startup/time_signal] started
namespace: /fetch15/application
fetch@fetch15:~/ros/indigo/src/jsk-ros-pkg/jsk_robot$ rosservice call /fetch15/start_app "name: 'jsk_fetch_startup/go_to_kitchen'" 
started: False
error_code: 511
message: app [jsk_fetch_startup/go_to_kitchen] is denied because app [jsk_fetch_startup/time_signal] is already running.
namespace: /fetch15/application
fetch@fetch15:~/ros/indigo/src/jsk-ros-pkg/jsk_robot$ 

cc. @k-okada

scripts/app_manager Outdated Show resolved Hide resolved
src/app_manager/app_manager.py Outdated Show resolved Hide resolved
@knorth55 knorth55 changed the title add enable_overwrite param in app_manager add enable_app_replacement param in app_manager Oct 14, 2020
@knorth55
Copy link
Contributor Author

I updated this PR to follow your advice.

@v4hn v4hn merged commit 4f30de2 into PR2:kinetic-devel Oct 15, 2020
@v4hn
Copy link
Member

v4hn commented Oct 15, 2020

Thanks @knorth55 .

@knorth55 heads-up from my side: my family just grew and now includes a new crying little kid.
So I will not have time to look at PR2 stuff over the next few months.
@k-okada please try to review new/open reviews from your lab and feel free to merge them if you consider them adequate.

@knorth55 knorth55 deleted the param-enable-overwrite branch October 15, 2020 22:48
@knorth55
Copy link
Contributor Author

@v4hn thank you for merging this PR.
OK, I will ask @k-okada for other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants