Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_robot_startup] set enable_app_replacement false in app_manager #1256

Merged
merged 6 commits into from
Jul 16, 2021
Merged

[jsk_robot_startup] set enable_app_replacement false in app_manager #1256

merged 6 commits into from
Jul 16, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Oct 13, 2020 •
edited
Loading

waiting for upstream
depends on PR2/app_manager#26
This PR disables overwriting apps in app_manager

@knorth55 knorth55 changed the title [wait for upstream][jsk_fetch_startup] set enable_overwrite false in app_manager [wait for upstream][jsk_robot_startup] set enable_overwrite false in app_manager Oct 13, 2020
@knorth55 knorth55 requested a review from 708yamaguchi October 13, 2020 15:24
@knorth55 knorth55 changed the title [wait for upstream][jsk_robot_startup] set enable_overwrite false in app_manager [waiting for upstream][jsk_robot_startup] set enable_overwrite false in app_manager Oct 13, 2020
This was referenced Oct 13, 2020
Closed
Closed
@knorth55 knorth55 changed the title [waiting for upstream][jsk_robot_startup] set enable_overwrite false in app_manager [waiting for upstream][jsk_robot_startup] set enable_app_replacement false in app_manager Oct 15, 2020
@knorth55 knorth55 added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update label Oct 16, 2020
@knorth55 knorth55 changed the title [waiting for upstream][jsk_robot_startup] set enable_app_replacement false in app_manager [jsk_robot_startup] set enable_app_replacement false in app_manager Oct 21, 2020
@knorth55 knorth55 added this to the 1.1.1 milestone Oct 21, 2020
@knorth55 knorth55 mentioned this pull request Nov 4, 2020
Open
12 tasks
@k-okada k-okada merged commit d33ea93 into jsk-ros-pkg:master Jul 16, 2021
@knorth55 knorth55 deleted the fetch-app-disable-overwrite branch July 16, 2021 10:06
This was referenced Sep 11, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi Awaiting requested review from 708yamaguchi

Assignees
No one assigned
Labels
enhancement fetch15 hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update MergeOK PR1040
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@knorth55 @k-okada