Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream/humble into feature branch #2

Merged

Conversation

sjahr
Copy link
Collaborator

@sjahr sjahr commented Apr 3, 2024

Merge upstream/humble into out feature branch to get f724da5 and avoid segfault

fmauch and others added 10 commits March 14, 2024 13:43
(cherry picked from commit 94745e6)

Co-authored-by: Graziato Davide <85335579+Fixit-Davide@users.noreply.github.com>
(cherry picked from commit a98cb2a)

Co-authored-by: Stephanie Eng <stephanie-eng@users.noreply.github.com>
ros-controls#257)

* Add dep (ros-controls#256)

(cherry picked from commit b35100d)

# Conflicts:
#	ign_ros2_control_demos/package.xml

* fixed merge

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
…ter `position_proportional_gain` (backport ros-controls#261) (ros-controls#262)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@sjahr sjahr changed the title Pr update mimic joint feature humble Merge upstream/humble into feature branch Apr 3, 2024
@sjahr sjahr requested review from EzraBrooks and MikeWrock April 3, 2024 09:56
Copy link

@MikeWrock MikeWrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it the get_parameter_or causing the segfault or something in the version bump fixes the issue?

@sjahr
Copy link
Collaborator Author

sjahr commented Apr 4, 2024

Was it the get_parameter_or causing the segfault or something in the version bump fixes the issue?

get_parameter_or without the try catch protection

1 similar comment
@sjahr
Copy link
Collaborator Author

sjahr commented Apr 4, 2024

Was it the get_parameter_or causing the segfault or something in the version bump fixes the issue?

get_parameter_or without the try catch protection

@sjahr sjahr merged commit c23e09c into mimic-joint-feature-humble Apr 4, 2024
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pr-update-mimic-joint-feature-humble branch April 4, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants