Add as_borrowed
conversion from gil-refs to Bound<T>
#3692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: we changed to add
.as_borrowed()
instead of.as_bound()
as it gave additional flexibility.This is the promised follow-up to #3686 which adds a
.as_bound()
method to the GIL refs API types to convert into the newBound<T>
smart pointer.I've switched all internal code over to use this API to give a feel of how it reads; I think it's much nicer to type and read
self.as_bound()
overBound::borrowed_from_gil_ref(&self)
. Hopefully this helps users to migrate.I think the next PR I plan to open will be a beginning of the migration guide entry; I'd just like this conversion API agreed upon first as this will form a key part of migration instructions.