implement PySetMethods and PyFrozenSetMethods
#3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
davidhewitt
force-pushed
the
set-frozenset
branch
from
8306f29
to
485c298
Compare
|
Looks like this need #3695 first for the |
This was referenced Dec 24, 2023
davidhewitt
force-pushed
the
set-frozenset
branch
from
485c298
to
459bb2a
Compare
davidhewitt
force-pushed
the
set-frozenset
branch
from
459bb2a
to
834da27
Compare
|
Thanks for the review; I've actioned all feedback save for the default methods where I'm not entirely sure on the ask. |
davidhewitt
force-pushed
the
set-frozenset
branch
from
834da27
to
cc1a6bf
Compare
davidhewitt
force-pushed
the
set-frozenset
branch
from
cc1a6bf
to
442d13d
Compare
adamreichold
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #3606. These types are very similar so I've paired them together.