introduce PyIterator::from_bound_object #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
bound-iterator-constructor
branch
from
20a71ba
to
de276b6
Compare
davidhewitt
force-pushed
the
bound-iterator-constructor
branch
from
de276b6
to
d034f61
Compare
adamreichold
reviewed
Jan 2, 2024
src/types/iterator.rs
Outdated
| pub(crate) fn from_object2<'py>(obj: &Bound<'py, PyAny>) -> PyResult<Bound<'py, PyIterator>> { | ||
| /// Constructs a `PyIterator` from a Python iterable object. | ||
| /// | ||
| /// Equivalent to Python's built-in `iter` function. |
There was a problem hiding this comment.
I think an intra doc link to PyAnyMethods::iter would be nice as this is usually the more convenient form compared to calling this directly.
adamreichold
approved these changes
Jan 2, 2024
davidhewitt
force-pushed
the
bound-iterator-constructor
branch
from
d034f61
to
783e98b
Compare
CodSpeed Performance ReportMerging #3702 will improve performances by 11.66%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the standard pattern we're now going for to introduce a new bound constructor while deprecating the old one.
This isn't mergeable until after #3694