Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement iterator for Bound iterator #3695

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

davidhewitt
Copy link
Member

Implements the ability to iterate Bound<'_, PyIterator> and &Bound<'_, PyIterator> in the same way that &'py PyIterator can already be iterated.

src/types/iterator.rs Outdated Show resolved Hide resolved
src/instance.rs Outdated Show resolved Hide resolved
src/types/iterator.rs Outdated Show resolved Hide resolved
src/types/iterator.rs Outdated Show resolved Hide resolved
@davidhewitt
Copy link
Member Author

Right, I've cleaned up this code and also cherry-picked the commit exposing from_bound_object from #3692

Copy link

codspeed-hq bot commented Dec 24, 2023

CodSpeed Performance Report

Merging #3695 will not alter performance

Comparing davidhewitt:bound-iterator (d669a94) with main (6ca63b5)

Summary

✅ 78 untouched benchmarks

@davidhewitt
Copy link
Member Author

Uff, that second commit depends on #3694 so to avoid a deadlock I've split that out into #3702. This PR is the first of the three that is mergeable 😮‍💨

@adamreichold adamreichold added this pull request to the merge queue Dec 25, 2023
Merged via the queue into PyO3:main with commit bd66053 Dec 25, 2023
55 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants