external_data: Enable test linting.

BUILD.bazel

@@ -56,6 +56,7 @@ filegroup(
  srcs = [
  "BUILD.bazel",
  "WORKSPACE",
+ ".bazelproject",
  ],
  visibility = ["//tools/external_data:__pkg__"],
 )

WORKSPACE

@@ -142,13 +142,9 @@ github_archive(
  build_file = "tools/workspace/styleguide/styleguide.BUILD.bazel", # noqa
 )
 
-github_archive(
- name = "pycodestyle",
- repository = "PyCQA/pycodestyle",
- commit = "2.3.1",
- sha256 = "e9fc1ca3fd85648f45c0d2e33591b608a17d8b9b78e22c5f898e831351bacb03", # noqa
- build_file = "tools/workspace/pycodestyle/pycodestyle.BUILD.bazel",
-)
+load("//tools/lint:lint_repositories.bzl", "lint_repositories")
+
+lint_repositories()
 
 bitbucket_archive(
  name = "eigen",
@@ -323,12 +319,6 @@ github_archive(
  build_file = "tools/workspace/yaml_cpp/yaml_cpp.BUILD.bazel",
 )
 
-load("//tools/workspace/buildifier:buildifier.bzl", "buildifier_repository")
-
-buildifier_repository(
- name = "buildifier",
-)
-
 load("//tools/workspace/gurobi:gurobi.bzl", "gurobi_repository")
 
 gurobi_repository(

tools/external_data/BUILD.bazel

@@ -6,8 +6,12 @@ drake_workspace_files = [
  ":all_files",
  "//tools/external_data/bazel_external_data:all_files",
  "//tools:all_files",
+ "//tools/install:all_files",
  "//tools/lint:all_files",
  "//tools/skylark:all_files",
+ "//tools/workspace:all_files",
+ "//tools/workspace/buildifier:all_files",
+ "//tools/workspace/pycodestyle:all_files",
  "//:skylark_files",
 ]
 

tools/external_data/test/workspaces/bazel_pkg_test/BUILD.bazel

@@ -1,5 +1,11 @@
 # -*- python -*-
 
-load("@drake//tools/external_data:external_data.bzl", "external_data_stub_test")
+load("@drake//tools/lint:lint.bzl", "add_lint_tests")
+load(
+ "@drake//tools/external_data:external_data.bzl",
+ "external_data_stub_test",
+)
 
 external_data_stub_test()
+
+add_lint_tests()

tools/external_data/test/workspaces/bazel_pkg_test/WORKSPACE

@@ -6,3 +6,7 @@ local_repository(
  name = "drake",
  path = dirname(__workspace_dir__, 5),
 )
+
+load("@drake//tools/lint:lint_repositories.bzl", "lint_repositories")
+
+lint_repositories()

tools/external_data/test/workspaces/bazel_pkg_test/tools/BUILD.bazel

@@ -1,3 +1,5 @@
 # -*- python -*-
 
-# Empty BUILD file to declare this directory as a package.
+load("@drake//tools/lint:lint.bzl", "add_lint_tests")
+
+add_lint_tests()

tools/install/BUILD.bazel

@@ -3,6 +3,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("//tools/lint:lint.bzl", "add_lint_tests")
+load("//tools/skylark:meta.bzl", "all_files")
 
 py_library(
  name = "cpsutils",
@@ -24,3 +25,5 @@ exports_files(
 )
 
 add_lint_tests()
+
+all_files()

tools/lint/lint_repositories.bzl

@@ -0,0 +1,26 @@
+load("//tools/workspace:github.bzl", "github_archive")
+load("//tools/workspace/buildifier:buildifier.bzl", "buildifier_repository")
+
+ALL = [
+ "pycodestyle",
+ "buildifier",
+]
+
+def lint_repositories(include = ALL):
+ if "pycodestyle" in include:
+ github_archive(
+ name = "pycodestyle",
+ repository = "PyCQA/pycodestyle",
+ commit = "2.3.1",
+ sha256 = "e9fc1ca3fd85648f45c0d2e33591b608a17d8b9b78e22c5f898e831351bacb03", # noqa
+ # `build_file` must be specified as a target `:` so that Bazel
+ # knows how to resolve it thorugh an external.
+ build_file = "@drake//tools/workspace/pycodestyle:pycodestyle.BUILD.bazel", # noqa
+ )
+
+ if "buildifier" in include:
+ buildifier_repository(
+ name = "buildifier",
+ )
+
+# No repositories for `clang-format`. It is used via the system.

tools/workspace/BUILD.bazel

@@ -7,6 +7,7 @@ load(
  "drake_py_binary",
 )
 load("//tools/lint:lint.bzl", "add_lint_tests")
+load("//tools/skylark:meta.bzl", "all_files")
 
 drake_py_binary(
  name = "cmake_configure_file",
@@ -58,3 +59,5 @@ install(
 check_licenses(_DRAKE_EXTERNAL_PACKAGE_INSTALLS)
 
 add_lint_tests()
+
+all_files()

tools/workspace/buildifier/BUILD.bazel

@@ -4,5 +4,8 @@
 # neighboring *.bzl file can be loaded elsewhere.
 
 load("//tools/lint:lint.bzl", "add_lint_tests")
+load("//tools/skylark:meta.bzl", "all_files")
 
 add_lint_tests()
+
+all_files()

tools/workspace/pycodestyle/BUILD.bazel

@@ -4,5 +4,8 @@
 # neighboring *.bzl file can be loaded elsewhere.
 
 load("//tools/lint:lint.bzl", "add_lint_tests")
+load("//tools/skylark:meta.bzl", "all_files")
 
 add_lint_tests()
+
+all_files()