-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept patch-level variation for GUROBI_HOME automatically #14157
Comments
This is conceptually easy, but a lot of boilerplate to wade through. The gurobi library's filename, packaged install location, etc. all incorporate the version number and are referred to in dozens of place by our CMake and Bazel integration alike. |
Drake currently supports 9.5.1. Per here we can see that 9.5.2 is already available. The call to action here is a PR to Drake so that either 9.5.1 or 9.5.2 can be used for the same revision of Drake when building from source, without any code changes. |
CMake's find_package_handle_standard_args() supports searching for an "exact" version containing only a major and minor version, allowing any patch version to suffice. Issue: RobotLocomotion#14157
Remove logic that limits Gurobi to 9.5.1, in order to support 9.5.x at any patch version. Update documentation accordingly. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
Remove logic that limits Gurobi to 9.5.1 and add logic to search for any available supported version, in order to support 9.5.x at any patch version. Update documentation accordingly. Modify FindGurobi.cmake to search for any patch version, not just one specific patch version. Fixes: RobotLocomotion#14157 Co-authored-by: Kyle Edwards <kyle.edwards@kitware.com>
+@BetsyMcPhail as a final item to prove that this patch works, please upgrade our CI images to use Gurobi 9.5.2 instead of Gurobi 9.5.1. |
For reference, #16604 updated Gurobi to 9.5.1. The checklist from that issue is below:
|
@svenevs and @williamjallen when you update the Linux AMIs for #18617 next week, do you want to also update the Gurobi version on the provisioned images? |
That seems reasonable to me. I was going to shadow Stephen on Monday anyway, and needed to ask him about updating Gurobi at the same time so we can knock out two things at once. |
The last step here is to update the Gurobi cask and the Mac images. @svenevs and @williamjallen can you please work together on this. |
Gurobi cask is updated and live at |
Orka has also been updated. Closing this issue. |
As of today, Drake is hardcoded to use only Gurobi version 9.0.2 (when enabled), but not all users will be able to easily obtain that exact version match. The download link from Gurobi's website is currently for 9.0.3.
Because Gurobi is commercially licensed software, users will typically bring their own copy (we can't provide one -- though see #10804 for related), so therefore it is difficult for us to control which version they are bringing. The Gurobi website also tends to remove the download links for prior releases (especially patch releases), so it's not obvious how to obtain the exact revision that Drake wants. (The trick is to just edit the download URL.)
We're already taking
GUROBI_HOME
as input from the user at fetch-time to know which Gurobi to use. It would be nice if any matching patch-level release (9.0.x) could be provided without complaint. As it stands now, we see:\CC @hongkai-dai
The text was updated successfully, but these errors were encountered: