Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FCL sha #10533

Closed
Closed

Conversation

hongkai-dai
Copy link
Contributor

@hongkai-dai hongkai-dai commented Jan 30, 2019

The newest FCL commit fixes a failure encountered in Drake simulation.

cc @avalenzu


This change is Reviewable

Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SeanCurtis-TRI for both reviews please, thanks!

Reviewable status: all discussions resolved, platform LGTM missing

@avalenzu
Copy link
Contributor

Looks like this is going to need some TLC to accommodate the changes to fcl::Convex introduced by flexible-collision-library/fcl#338.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @DamrongGuoy is currently on cleaning up the Convex stuff. When he does, we'll replace this PR with another.

Reviewable status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM missing (waiting on @SeanCurtis-TRI)

@SeanCurtis-TRI
Copy link
Contributor

Superseded by #10539

@hongkai-dai hongkai-dai deleted the update_fcl_sha branch March 6, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants