Do not exclude all sh tests when running under Valgrind Memcheck #11716
Conversation
jamiesnape
added
unused team: kitware
unused type: valgrind-memcheck
|
@drake-jenkins-bot linux-bionic-clang-bazel-experimental-everything-valgrind-memcheck please |
|
+@EricCousineau-TRI for feature review. |
There was a problem hiding this comment.
Just to make sure that I have a good grasp of this campaign, is there an issue that can track this?
(Is this towards being able to more easily solve Python problems like #11424?)
Reviewed 20 of 20 files at r1.
Reviewable status: needs at least two assigned reviewers
Yes (running tests that use the Python test runner is an upcoming PR). |
|
Gotcha. So the next arc is to add some dynamic analysis for |
There was a problem hiding this comment.
+@soonho-tri for platform review, please.
Reviewable status: LGTM missing from assignee soonho-tri(platform) (waiting on @soonho-tri)
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees soonho-tri(platform),EricCousineau-TRI(platform)
Also remove some outdated/superfluous
no_memchecktags (e.g., related to Xenial, Mac, and/or when we compiled with-O1instead of-O2). We did have defects in some of the tests excluded by tags or language filters (which were fixed after being revealed by early drafts of these PR).This change is