Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydrake: Rename a unittest method to avoid determinism bug #11719

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jun 24, 2019

This test case fails under python3 -c dbg with certain names, but not others. This works around spurious failures that show up as of commit 12a8432.

Closes #11718.


This change is Reviewable

This test case fails under python3 -c dbg with certain names, but not others.
This works around spurios failures that show up as of commit
12a8432.
@jwnimmer-tri jwnimmer-tri added priority: emergency status: single reviewer ok https://drake.mit.edu/reviewable.html labels Jun 24, 2019
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-bionic-clang-bazel-experimental-everything-python3-debug please
@drake-jenkins-bot linux-bionic-clang-bazel-experimental-python3-debug please
@drake-jenkins-bot linux-bionic-gcc-bazel-experimental-everything-python3-debug please
@drake-jenkins-bot linux-bionic-gcc-bazel-experimental-python3-debug please

@jwnimmer-tri
Copy link
Collaborator Author

+@EricCousineau-TRI for both reviews, please. (Still waiting on CI, but this fixed it for me locally.)

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, but :lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit c8e18eb into RobotLocomotion:master Jun 24, 2019
@jwnimmer-tri jwnimmer-tri deleted the randomer branch June 24, 2019 22:44
antequ pushed a commit to antequ-TRI/drake that referenced this pull request Jul 1, 2019
…motion#11719)

This test case fails under python3 -c dbg with certain names, but not others.
This works around spurious failures that show up as of commit
12a8432.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: emergency status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants