Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Use ™ on MOSEK and always capitalize it #16576

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 11, 2022

This changes Drake's published documentation and API help to follow the preferred trademark spelling. Various buried mentions in our private source files are unchanged.

For the website, automatically hyperlink ™ to a trademarks page.

Towards #16439.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added the release notes: none This pull request should not be mentioned in the release notes label Feb 11, 2022
This changes Drake's published documentation and API to follow the
preferred trademark spelling. Various buried mentions in our private
source files are unchanged.

For the website, automatically hyperlink ™ to a trademarks page.
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for feature review, please.

@BetsyMcPhail

This comment was marked as resolved.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: needs at least two assigned reviewers (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

+@sherm1 for platform review per schedule (tomorrow), please.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm: (one question)

Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)


tools/install/check_licenses.bzl, line 12 at r1 (raw file):

    "EULA.pdf",  # @gurobi
    "LICENSE",
    "mosek-eula.pdf",  # @mosek

BTW what do the "@" signs accomplish here?

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion (waiting on @sherm1)


tools/install/check_licenses.bzl, line 12 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW what do the "@" signs accomplish here?

Nothing functional. By adding them, I was trying to indicate that these are Bazel labels (ala deps = ["@ccd"] in a BUILD file), not the actual project's names.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform) (waiting on @jwnimmer-tri)


tools/install/check_licenses.bzl, line 12 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Nothing functional. By adding them, I was trying to indicate that these are Bazel labels (ala deps = ["@ccd"] in a BUILD file), not the actual project's names.

Thanks!

@sherm1 sherm1 merged commit 9064855 into RobotLocomotion:master Feb 15, 2022
@jwnimmer-tri jwnimmer-tri deleted the doc-mosek-tm branch February 15, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants