-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Use ™ on MOSEK and always capitalize it #16576
Conversation
90be92b
to
e884271
Compare
This changes Drake's published documentation and API to follow the preferred trademark spelling. Various buried mentions in our private source files are unchanged. For the website, automatically hyperlink ™ to a trademarks page.
e884271
to
1fcaf32
Compare
+@rpoyner-tri for feature review, please. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: needs at least two assigned reviewers (waiting on @jwnimmer-tri)
+@sherm1 for platform review per schedule (tomorrow), please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/install/check_licenses.bzl, line 12 at r1 (raw file):
"EULA.pdf", # @gurobi "LICENSE", "mosek-eula.pdf", # @mosek
BTW what do the "@" signs accomplish here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion (waiting on @sherm1)
tools/install/check_licenses.bzl, line 12 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
BTW what do the "@" signs accomplish here?
Nothing functional. By adding them, I was trying to indicate that these are Bazel labels (ala deps = ["@ccd"]
in a BUILD file), not the actual project's names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform) (waiting on @jwnimmer-tri)
tools/install/check_licenses.bzl, line 12 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Nothing functional. By adding them, I was trying to indicate that these are Bazel labels (ala
deps = ["@ccd"]
in a BUILD file), not the actual project's names.
Thanks!
This changes Drake's published documentation and API help to follow the preferred trademark spelling. Various buried mentions in our private source files are unchanged.
For the website, automatically hyperlink ™ to a trademarks page.
Towards #16439.
This change is